chrome/browser/resources/settings/people_page/sync_browser_proxy.js - Issue 2920853004: [sync] Display an error when sync settings aren't confirmed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/sync_browser_proxy.js

Issue 2920853004: [sync] Display an error when sync settings aren't confirmed (Closed)

Patch Set: initialize button to nullptr Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/people_page/sync_browser_proxy.js

diff --git a/chrome/browser/resources/settings/people_page/sync_browser_proxy.js b/chrome/browser/resources/settings/people_page/sync_browser_proxy.js

index 572dcb4f9c04bd9ee3d49f9f89f2bac1eba626f4..d3fe5a17b6b4856175986d146bcdd64f1b170655 100644

--- a/chrome/browser/resources/settings/people_page/sync_browser_proxy.js

+++ b/chrome/browser/resources/settings/people_page/sync_browser_proxy.js

@@ -40,6 +40,8 @@ settings.StatusAction = {

SIGNOUT_AND_SIGNIN: 'signOutAndSignIn', // User needs to sign out and sign in.

UPGRADE_CLIENT: 'upgradeClient', // User needs to upgrade the client.

ENTER_PASSPHRASE: 'enterPassphrase', // User needs to enter passphrase.

+ CONFIRM_SYNC_SETTINGS: "confirmSyncSettings",

tommycli 2017/06/12 18:41:01 nit: We use single quotes in JS for strings. Unfor

Patrick Noland 2017/06/12 18:44:30 Done.

+ // User needs to confirm sync settings.

};

/**

« no previous file with comments | « chrome/browser/resources/settings/people_page/people_page.js ('k') | chrome/browser/sync/sync_ui_util.h » ('j') | no next file with comments »