[sync] Display an error when sync settings aren't confirmed

chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h"
 
 #include <memory>
 
 #include "base/command_line.h"
 #import "base/mac/foundation_util.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/macros.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/gcm/fake_gcm_profile_service.h"
 #include "chrome/browser/gcm/gcm_profile_service_factory.h"
 #include "chrome/browser/profiles/avatar_menu.h"
 #include "chrome/browser/profiles/profile_attributes_entry.h"
 #include "chrome/browser/profiles/profile_attributes_storage.h"
 #include "chrome/browser/signin/account_fetcher_service_factory.h"
 #include "chrome/browser/signin/account_tracker_service_factory.h"
 #include "chrome/browser/signin/chrome_signin_helper.h"
 #include "chrome/browser/signin/fake_account_fetcher_service_builder.h"
 #include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h"
 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
+#include "chrome/browser/sync/profile_sync_service_factory.h"
+#include "chrome/browser/sync/profile_sync_test_util.h"
 #include "chrome/browser/ui/browser.h"
 #import "chrome/browser/ui/cocoa/info_bubble_view.h"
 #include "chrome/browser/ui/cocoa/l10n_util.h"
 #include "chrome/browser/ui/cocoa/test/cocoa_profile_test.h"
 #include "chrome/browser/ui/cocoa/test/scoped_force_rtl_mac.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "components/signin/core/browser/fake_account_fetcher_service.h"
 #include "components/signin/core/browser/fake_profile_oauth2_token_service.h"
 #include "components/signin/core/browser/profile_oauth2_token_service.h"
 #include "components/signin/core/browser/signin_manager.h"
 #include "components/signin/core/common/profile_management_switches.h"
 #include "components/signin/core/common/signin_pref_names.h"
 #include "components/sync_preferences/pref_service_syncable.h"
 
+using ::testing::Return;
+
 const std::string kGaiaId = "gaiaid-user@gmail.com";
 const std::string kEmail = "user@gmail.com";
 const std::string kSecondaryEmail = "user2@gmail.com";
 const std::string kSecondaryGaiaId = "gaiaid-user2@gmail.com";
 const std::string kLoginToken = "oauth2_login_token";
 
 class ProfileChooserControllerTest : public CocoaProfileTest {
  public:
   ProfileChooserControllerTest() {
     TestingProfile::TestingFactories factories;
     factories.push_back(
         std::make_pair(ProfileOAuth2TokenServiceFactory::GetInstance(),
                        BuildFakeProfileOAuth2TokenService));
     factories.push_back(
         std::make_pair(AccountFetcherServiceFactory::GetInstance(),
                        FakeAccountFetcherServiceBuilder::BuildForTests));
+    factories.push_back(std::make_pair(ProfileSyncServiceFactory::GetInstance(),
+                                       BuildMockProfileSyncService));
     AddTestingFactories(factories);
   }
 
   void SetUp() override {
     CocoaProfileTest::SetUp();
 
     ASSERT_TRUE(browser()->profile());
 
     gcm::GCMProfileServiceFactory::GetInstance()->SetTestingFactory(
         browser()->profile(), gcm::FakeGCMProfileService::Build);
 
     testing_profile_manager()->CreateTestingProfile(
         "test1", std::unique_ptr<sync_preferences::PrefServiceSyncable>(),
         base::ASCIIToUTF16("Test 1"), 0, std::string(), testing_factories());
     testing_profile_manager()->CreateTestingProfile(
         "test2", std::unique_ptr<sync_preferences::PrefServiceSyncable>(),
         base::ASCIIToUTF16("Test 2"), 1, std::string(),
         TestingProfile::TestingFactories());
 
+    mock_sync_service_ = static_cast<browser_sync::ProfileSyncServiceMock*>(
+        ProfileSyncServiceFactory::GetInstance()->GetForProfile(
+            browser()->profile()));
+
     menu_ = new AvatarMenu(
         testing_profile_manager()->profile_attributes_storage(), NULL, NULL);
     menu_->RebuildMenu();
 
     // There should be the default profile + two profiles we created.
     EXPECT_EQ(3U, menu_->GetNumberOfItems());
   }
 
   void TearDown() override {
     [controller() close];
@@ skipping 15 matching lines @@
   }
 
   void SignInFirstProfile() {
     std::vector<ProfileAttributesEntry*> entries = testing_profile_manager()->
         profile_attributes_storage()->GetAllProfilesAttributes();
     ASSERT_LE(1U, entries.size());
     ProfileAttributesEntry* entry = entries.front();
     entry->SetAuthInfo(kGaiaId, base::ASCIIToUTF16(kEmail));
   }
 
+  void SuppressSyncConfirmationError() {
+    EXPECT_CALL(*mock_sync_service_, IsFirstSetupComplete())
+        .WillRepeatedly(Return(false));
+    EXPECT_CALL(*mock_sync_service_, IsFirstSetupInProgress())
+        .WillRepeatedly(Return(true));
+    EXPECT_CALL(*mock_sync_service_, IsSyncConfirmationNeeded())
+        .WillRepeatedly(Return(false));
+  }
+
   ProfileChooserController* controller() { return controller_; }
   AvatarMenu* menu() { return menu_; }
 
  private:
   base::scoped_nsobject<ProfileChooserController> controller_;
+  browser_sync::ProfileSyncServiceMock* mock_sync_service_ = nullptr;
 
   // Weak; owned by |controller_|.
   AvatarMenu* menu_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileChooserControllerTest);
 };
 
 TEST_F(ProfileChooserControllerTest, InitialLayoutWithNewMenu) {
   StartProfileChooserController();
 
@@ skipping 156 matching lines @@
       ->SetAuthenticatedAccountInfo(kGaiaId, kEmail);
   std::string account_id =
       SigninManagerFactory::GetForProfile(profile)->GetAuthenticatedAccountId();
   ProfileOAuth2TokenServiceFactory::GetForProfile(profile)
       ->UpdateCredentials(account_id, kLoginToken);
   account_id = AccountTrackerServiceFactory::GetForProfile(profile)
                    ->PickAccountIdForAccount(kSecondaryGaiaId, kSecondaryEmail);
   ProfileOAuth2TokenServiceFactory::GetForProfile(profile)
       ->UpdateCredentials(account_id, kLoginToken);
 
+  SuppressSyncConfirmationError();
+
   StartProfileChooserController();
   [controller() initMenuContentsWithView:
       profiles::BUBBLE_VIEW_MODE_ACCOUNT_MANAGEMENT];
 
   NSArray* subviews = [[[controller() window] contentView] subviews];
   ASSERT_EQ(2U, [subviews count]);
   subviews = [[subviews objectAtIndex:0] subviews];
 
   // There should be one active card, one accounts container, two separators
   // and one option buttons view. In the MD User Menu, there are 2 more buttons.
@@ skipping 98 matching lines @@
   ASSERT_EQ(3U, [buttonSubviews count]);
 
   // There should be a lock button.
   NSButton* lockButton =
       base::mac::ObjCCast<NSButton>([buttonSubviews objectAtIndex:0]);
   ASSERT_TRUE(lockButton);
   EXPECT_EQ(@selector(lockProfile:), [lockButton action]);
   EXPECT_EQ(controller(), [lockButton target]);
   EXPECT_TRUE([lockButton isEnabled]);
 }