[sync] Display an error when sync settings aren't confirmed

chrome/browser/resources/settings/people_page/sync_browser_proxy.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview A helper object used from the the People section to get the
  * status of the sync backend and user preferences on what data to sync. Used
  * for both Chrome browser and ChromeOS.
  */
 cr.exportPath('settings');
@@ skipping 22 matching lines @@
  * Must be kept in sync with the return values of getSyncErrorAction in
  * chrome/browser/ui/webui/settings/people_handler.cc
  * @enum {string}
  */
 settings.StatusAction = {
   NO_ACTION: 'noAction',                  // No action to take.
   REAUTHENTICATE: 'reauthenticate',       // User needs to reauthenticate.
   SIGNOUT_AND_SIGNIN: 'signOutAndSignIn', // User needs to sign out and sign in.
   UPGRADE_CLIENT: 'upgradeClient',        // User needs to upgrade the client.
   ENTER_PASSPHRASE: 'enterPassphrase',    // User needs to enter passphrase.
+  CONFIRM_SYNC_SETTINGS: "confirmSyncSettings",

[tommycli, 2017/06/12 18:41:01]

nit: We use single quotes in JS for strings. Unfortunate that the comment
doesn't fit. Maybe on top would be better than on bottom?

Run 'git cl format --js' afterwards too to see if it has an opinion.

[Patrick Noland, 2017/06/12 18:44:30]

Done.

+  // User needs to confirm sync settings.
 };
 
 /**
  * The state of sync. This is the data structure sent back and forth between
  * C++ and JS. Its naming and structure is not optimal, but changing it would
  * require changes to the C++ handler, which is already functional.
  * @typedef {{
  *   appsEnforced: boolean,
  *   appsRegistered: boolean,
  *   appsSynced: boolean,
@@ skipping 180 matching lines @@
       chrome.metricsPrivate.recordUserAction(
           'Signin_AccountSettings_GoogleActivityControlsClicked');
     }
   };
 
   return {
     SyncBrowserProxy: SyncBrowserProxy,
     SyncBrowserProxyImpl: SyncBrowserProxyImpl,
   };
 });