Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 2920733004: Reenable vm tests with -cdartk DFE parser. (Closed)

Created:
3 years, 6 months ago by aam
Modified:
3 years, 6 months ago
Reviewers:
alexander2, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reenable vm tests with -cdartk DFE parser. This was accidentally disabled in 7e2d9ac85de41122144be246f10700ec2d5c715b. BUG=#28264 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/6573c74301eecc606d8a4f3a7d6e57f86cf1b4ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -15 lines) Patch
M runtime/tests/vm/vm.status View 7 chunks +2 lines, -14 lines 0 comments Download
M tools/testing/dart/test_configurations.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
alexander2
3 years, 6 months ago (2017-06-02 01:01:23 UTC) #2
siva
lgtm
3 years, 6 months ago (2017-06-02 15:31:50 UTC) #3
aam
3 years, 6 months ago (2017-06-02 16:34:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6573c74301eecc606d8a4f3a7d6e57f86cf1b4ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698