[AiS] Bring Answers from C++ to Java.

[AiS] Bring Answers from C++ to Java.

This change gets potential Answers to the Java side of things, enabling
rendering in the Omnibox

BUG=370192
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272049

[groby-ooo-7-16, 2014-05-20 00:57:36]

PTAL. dtrainor for Androidiness/Javaness, Maria specifically for Answers

[Maria, 2014-05-20 01:05:00]

lgtm

https://codereview.chromium.org/292073002/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestion.java
(right):

https://codereview.chromium.org/292073002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestion.java:110:
String formattedUrl, boolean isStarred, boolean isDeletable) {
Please delete this constructor after after submitting this change and updating
clank callers to use the one above. I would like to make sure we don't have a
proliferation of constructors for this.

https://codereview.chromium.org/292073002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestion.java:197:
&& mAnswerContents.equals(suggestion.mAnswerContents)
this line seems unnecessary since we already check that in answersAreEqual

[David Trainor- moved to gerrit, 2014-05-20 18:13:55]

lgtm

https://chromiumcodereview.appspot.com/292073002/diff/1/chrome/android/java/s...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestion.java
(right):

https://chromiumcodereview.appspot.com/292073002/diff/1/chrome/android/java/s...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestion.java:176:
hash = hash + mAnswerContents.hashCode();
{} around if block or put on same line.

[groby-ooo-7-16, 2014-05-20 22:32:13]

https://codereview.chromium.org/292073002/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestion.java
(right):

https://codereview.chromium.org/292073002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestion.java:110:
String formattedUrl, boolean isStarred, boolean isDeletable) {
On 2014/05/20 01:05:00, Maria wrote:
> Please delete this constructor after after submitting this change and updating
> clank callers to use the one above. I would like to make sure we don't have a
> proliferation of constructors for this.

That was the plan. Filed crbug/375482 to track, added comment.

https://codereview.chromium.org/292073002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestion.java:176:
hash = hash + mAnswerContents.hashCode();
On 2014/05/20 18:13:56, David Trainor wrote:
> {} around if block or put on same line.

Done.

https://codereview.chromium.org/292073002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestion.java:197:
&& mAnswerContents.equals(suggestion.mAnswerContents)
On 2014/05/20 01:05:00, Maria wrote:
> this line seems unnecessary since we already check that in answersAreEqual

Forgot to delete - thanks for catching!

[groby-ooo-7-16, 2014-05-20 22:32:17]

The CQ bit was checked by groby@chromium.org

[commit-bot: I haz the power, 2014-05-20 22:34:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/groby@chromium.org/292073002/20001

[commit-bot: I haz the power, 2014-05-21 07:49:49]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-21 20:04:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-21 20:04:59]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[groby-ooo-7-16, 2014-05-22 01:58:55]

The CQ bit was checked by groby@chromium.org

[commit-bot: I haz the power, 2014-05-22 02:02:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/groby@chromium.org/292073002/20001

[commit-bot: I haz the power, 2014-05-22 02:50:50]

Change committed as 272049