Class/struct layout optimization for blink Resource related classes

third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h

 /*
  * Copyright (C) 2003, 2006 Apple Computer, Inc.  All rights reserved.
  * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 25 matching lines @@
 #include "platform/network/HTTPParsers.h"
 #include "platform/weborigin/KURL.h"
 #include "platform/weborigin/Referrer.h"
 #include "platform/weborigin/SecurityOrigin.h"
 #include "platform/wtf/RefCounted.h"
 #include "public/platform/WebAddressSpace.h"
 #include "public/platform/WebURLRequest.h"
 
 namespace blink {
 
-enum class WebCachePolicy;
+enum class WebCachePolicy : uint8_t;
 
 enum class ResourceRequestBlockedReason {
   CSP,
   kMixedContent,
   kOrigin,
   kInspector,
   kSubresourceFilter,
   kOther,
   kNone
 };
 
-enum InputToLoadPerfMetricReportPolicy {
+enum InputToLoadPerfMetricReportPolicy : uint8_t {
   kNoReport,    // Don't report metrics for this ResourceRequest.
   kReportLink,  // Report metrics for this request as initiated by a link click.
   kReportIntent,  // Report metrics for this request as initiated by an intent.
 };
 
 struct CrossThreadResourceRequestData;
 
 class PLATFORM_EXPORT ResourceRequest final {
   DISALLOW_NEW();
 
  public:
-  enum class RedirectStatus { kFollowedRedirect, kNoRedirect };
+  enum class RedirectStatus : uint8_t { kFollowedRedirect, kNoRedirect };
 
   class ExtraData : public RefCounted<ExtraData> {
    public:
     virtual ~ExtraData() {}
   };
 
   ResourceRequest();
   explicit ResourceRequest(const String& url_string);
   explicit ResourceRequest(const KURL&);
   explicit ResourceRequest(CrossThreadResourceRequestData*);
@@ skipping 247 matching lines @@
     is_same_document_navigation_ = is_same_document;
   }
   bool IsSameDocumentNavigation() const { return is_same_document_navigation_; }
 
  private:
   const CacheControlHeader& GetCacheControlHeader() const;
 
   bool NeedsHTTPOrigin() const;
 
   KURL url_;
-  WebCachePolicy cache_policy_;
   double timeout_interval_;  // 0 is a magic value for platform default on
                              // platforms that have one.
   KURL first_party_for_cookies_;
   RefPtr<SecurityOrigin> requestor_origin_;
   AtomicString http_method_;
   HTTPHeaderMap http_header_fields_;
   RefPtr<EncodedFormData> http_body_;
   RefPtr<EncodedFormData> attached_credential_;
   bool allow_stored_credentials_ : 1;
   bool report_upload_progress_ : 1;
   bool report_raw_headers_ : 1;
   bool has_user_gesture_ : 1;
   bool download_to_file_ : 1;
   bool use_stream_on_response_ : 1;
   bool keepalive_ : 1;
   bool should_reset_app_cache_ : 1;
+  WebCachePolicy cache_policy_;
   WebURLRequest::ServiceWorkerMode service_worker_mode_;
   ResourceLoadPriority priority_;
   int intra_priority_value_;
   int requestor_id_;
   int requestor_process_id_;
   int app_cache_host_id_;
+  WebURLRequest::PreviewsState previews_state_;
   RefPtr<ExtraData> extra_data_;
   WebURLRequest::RequestContext request_context_;
   WebURLRequest::FrameType frame_type_;
   WebURLRequest::FetchRequestMode fetch_request_mode_;
   WebURLRequest::FetchCredentialsMode fetch_credentials_mode_;
   WebURLRequest::FetchRedirectMode fetch_redirect_mode_;
-  WebURLRequest::PreviewsState previews_state_;
   ReferrerPolicy referrer_policy_;
   bool did_set_http_referrer_;
   bool check_for_browser_side_navigation_;
   double ui_start_time_;
   bool is_external_request_;
   WebURLRequest::LoadingIPCType loading_ipc_type_;
   bool is_same_document_navigation_;
   InputToLoadPerfMetricReportPolicy input_perf_metric_report_policy_;
+  RedirectStatus redirect_status_;
 
   mutable CacheControlHeader cache_control_header_cache_;
 
   static double default_timeout_interval_;
 
-  RedirectStatus redirect_status_;
-
   double navigation_start_ = 0;
 };
 
 struct CrossThreadResourceRequestData {
   WTF_MAKE_NONCOPYABLE(CrossThreadResourceRequestData);
   USING_FAST_MALLOC(CrossThreadResourceRequestData);
 
  public:
   CrossThreadResourceRequestData() {}
   KURL url_;
@@ skipping 32 matching lines @@
   double ui_start_time_;
   bool is_external_request_;
   WebURLRequest::LoadingIPCType loading_ipc_type_;
   InputToLoadPerfMetricReportPolicy input_perf_metric_report_policy_;
   ResourceRequest::RedirectStatus redirect_status_;
 };
 
 }  // namespace blink
 
 #endif  // ResourceRequest_h