Class/struct layout optimization for blink Resource related classes

third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.cpp

 /*
  * Copyright (C) 2006, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 57 matching lines @@
 ResourceResponse::SignedCertificateTimestamp::IsolatedCopy() const {
   return SignedCertificateTimestamp(
       status_.IsolatedCopy(), origin_.IsolatedCopy(),
       log_description_.IsolatedCopy(), log_id_.IsolatedCopy(), timestamp_,
       hash_algorithm_.IsolatedCopy(), signature_algorithm_.IsolatedCopy(),
       signature_data_.IsolatedCopy());
 }
 
 ResourceResponse::ResourceResponse()
     : expected_content_length_(0),
+      connection_id_(0),
       http_status_code_(0),
+      remote_port_(0),
       was_cached_(false),
-      connection_id_(0),
       connection_reused_(false),
       is_null_(true),
       have_parsed_age_header_(false),
       have_parsed_date_header_(false),
       have_parsed_expires_header_(false),
       have_parsed_last_modified_header_(false),
-      age_(0.0),
-      date_(0.0),
-      expires_(0.0),
-      last_modified_(0.0),
       has_major_certificate_errors_(false),
-      security_style_(kSecurityStyleUnknown),
-      http_version_(kHTTPVersionUnknown),
-      app_cache_id_(0),
       was_fetched_via_spdy_(false),
       was_fetched_via_proxy_(false),
       was_fetched_via_service_worker_(false),
       was_fetched_via_foreign_fetch_(false),
       was_fallback_required_by_service_worker_(false),
+      did_service_worker_navigation_preload_(false),
       service_worker_response_type_(kWebServiceWorkerResponseTypeDefault),
-      did_service_worker_navigation_preload_(false),
+      http_version_(kHTTPVersionUnknown),
+      security_style_(kSecurityStyleUnknown),
+      age_(0.0),
+      date_(0.0),
+      expires_(0.0),
+      last_modified_(0.0),
+      app_cache_id_(0),
       response_time_(0),
-      remote_port_(0),
       encoded_data_length_(0),
       encoded_body_length_(0),
       decoded_body_length_(0) {}
 
 ResourceResponse::ResourceResponse(const KURL& url,
                                    const AtomicString& mime_type,
                                    long long expected_length,
                                    const AtomicString& text_encoding_name)
     : url_(url),
       mime_type_(mime_type),
       expected_content_length_(expected_length),
       text_encoding_name_(text_encoding_name),
+      connection_id_(0),
       http_status_code_(0),
+      remote_port_(0),
       was_cached_(false),
-      connection_id_(0),
       connection_reused_(false),
       is_null_(false),
       have_parsed_age_header_(false),
       have_parsed_date_header_(false),
       have_parsed_expires_header_(false),
       have_parsed_last_modified_header_(false),
-      age_(0.0),
-      date_(0.0),
-      expires_(0.0),
-      last_modified_(0.0),
       has_major_certificate_errors_(false),
-      security_style_(kSecurityStyleUnknown),
-      http_version_(kHTTPVersionUnknown),
-      app_cache_id_(0),
       was_fetched_via_spdy_(false),
       was_fetched_via_proxy_(false),
       was_fetched_via_service_worker_(false),
       was_fetched_via_foreign_fetch_(false),
       was_fallback_required_by_service_worker_(false),
+      did_service_worker_navigation_preload_(false),
       service_worker_response_type_(kWebServiceWorkerResponseTypeDefault),
-      did_service_worker_navigation_preload_(false),
+      http_version_(kHTTPVersionUnknown),
+      security_style_(kSecurityStyleUnknown),
+      age_(0.0),
+      date_(0.0),
+      expires_(0.0),
+      last_modified_(0.0),
+      app_cache_id_(0),
       response_time_(0),
-      remote_port_(0),
       encoded_data_length_(0),
       encoded_body_length_(0),
       decoded_body_length_(0) {}
 
 ResourceResponse::ResourceResponse(CrossThreadResourceResponseData* data)
     : ResourceResponse() {
   SetURL(data->url_);
   SetMimeType(AtomicString(data->mime_type_));
   SetExpectedContentLength(data->expected_content_length_);
   SetTextEncodingName(AtomicString(data->text_encoding_name_));
 
   SetHTTPStatusCode(data->http_status_code_);
   SetHTTPStatusText(AtomicString(data->http_status_text_));
 
   http_header_fields_.Adopt(std::move(data->http_headers_));
   SetResourceLoadTiming(std::move(data->resource_load_timing_));
+  remote_ip_address_ = AtomicString(data->remote_ip_address_);
+  remote_port_ = data->remote_port_;
   has_major_certificate_errors_ = data->has_major_certificate_errors_;
+  was_fetched_via_spdy_ = data->was_fetched_via_spdy_;
+  was_fetched_via_proxy_ = data->was_fetched_via_proxy_;
+  was_fetched_via_service_worker_ = data->was_fetched_via_service_worker_;
+  was_fetched_via_foreign_fetch_ = data->was_fetched_via_foreign_fetch_;
+  was_fallback_required_by_service_worker_ =
+      data->was_fallback_required_by_service_worker_;
+  did_service_worker_navigation_preload_ =
+      data->did_service_worker_navigation_preload_;
+  service_worker_response_type_ = data->service_worker_response_type_;
   security_style_ = data->security_style_;
   security_details_.protocol = data->security_details_.protocol;
   security_details_.cipher = data->security_details_.cipher;
   security_details_.key_exchange = data->security_details_.key_exchange;
   security_details_.key_exchange_group =
       data->security_details_.key_exchange_group;
   security_details_.mac = data->security_details_.mac;
   security_details_.subject_name = data->security_details_.subject_name;
   security_details_.san_list = data->security_details_.san_list;
   security_details_.issuer = data->security_details_.issuer;
   security_details_.valid_from = data->security_details_.valid_from;
   security_details_.valid_to = data->security_details_.valid_to;
   for (auto& cert : data->certificate_)
     security_details_.certificate.push_back(AtomicString(cert));
   security_details_.sct_list = data->security_details_.sct_list;
   http_version_ = data->http_version_;
   app_cache_id_ = data->app_cache_id_;
   app_cache_manifest_url_ = data->app_cache_manifest_url_.Copy();
   multipart_boundary_ = data->multipart_boundary_;
-  was_fetched_via_spdy_ = data->was_fetched_via_spdy_;
-  was_fetched_via_proxy_ = data->was_fetched_via_proxy_;
-  was_fetched_via_service_worker_ = data->was_fetched_via_service_worker_;
-  was_fetched_via_foreign_fetch_ = data->was_fetched_via_foreign_fetch_;
-  was_fallback_required_by_service_worker_ =
-      data->was_fallback_required_by_service_worker_;
-  service_worker_response_type_ = data->service_worker_response_type_;
   url_list_via_service_worker_ = data->url_list_via_service_worker_;
   cache_storage_cache_name_ = data->cache_storage_cache_name_;
-  did_service_worker_navigation_preload_ =
-      data->did_service_worker_navigation_preload_;
   response_time_ = data->response_time_;
-  remote_ip_address_ = AtomicString(data->remote_ip_address_);
-  remote_port_ = data->remote_port_;
   encoded_data_length_ = data->encoded_data_length_;
   encoded_body_length_ = data->encoded_body_length_;
   decoded_body_length_ = data->decoded_body_length_;
   downloaded_file_path_ = data->downloaded_file_path_;
   downloaded_file_handle_ = data->downloaded_file_handle_;
 
   // Bug https://bugs.webkit.org/show_bug.cgi?id=60397 this doesn't support
   // whatever values may be present in the opaque m_extraData structure.
 }
 
 ResourceResponse::ResourceResponse(const ResourceResponse&) = default;
 ResourceResponse& ResourceResponse::operator=(const ResourceResponse&) =
     default;
 
 std::unique_ptr<CrossThreadResourceResponseData> ResourceResponse::CopyData()
     const {
   std::unique_ptr<CrossThreadResourceResponseData> data =
       WTF::WrapUnique(new CrossThreadResourceResponseData);
   data->url_ = Url().Copy();
   data->mime_type_ = MimeType().GetString().IsolatedCopy();
   data->expected_content_length_ = ExpectedContentLength();
   data->text_encoding_name_ = TextEncodingName().GetString().IsolatedCopy();
   data->http_status_code_ = HttpStatusCode();
   data->http_status_text_ = HttpStatusText().GetString().IsolatedCopy();
   data->http_headers_ = HttpHeaderFields().CopyData();
   if (resource_load_timing_)
     data->resource_load_timing_ = resource_load_timing_->DeepCopy();
+  data->remote_ip_address_ = remote_ip_address_.GetString().IsolatedCopy();
+  data->remote_port_ = remote_port_;
   data->has_major_certificate_errors_ = has_major_certificate_errors_;
+  data->was_fetched_via_spdy_ = was_fetched_via_spdy_;
+  data->was_fetched_via_proxy_ = was_fetched_via_proxy_;
+  data->was_fetched_via_service_worker_ = was_fetched_via_service_worker_;
+  data->was_fetched_via_foreign_fetch_ = was_fetched_via_foreign_fetch_;
+  data->was_fallback_required_by_service_worker_ =
+      was_fallback_required_by_service_worker_;
+  data->did_service_worker_navigation_preload_ =
+      did_service_worker_navigation_preload_;
+  data->service_worker_response_type_ = service_worker_response_type_;
   data->security_style_ = security_style_;
   data->security_details_.protocol = security_details_.protocol.IsolatedCopy();
   data->security_details_.cipher = security_details_.cipher.IsolatedCopy();
   data->security_details_.key_exchange =
       security_details_.key_exchange.IsolatedCopy();
   data->security_details_.key_exchange_group =
       security_details_.key_exchange_group.IsolatedCopy();
   data->security_details_.mac = security_details_.mac.IsolatedCopy();
   data->security_details_.subject_name =
       security_details_.subject_name.IsolatedCopy();
   data->security_details_.san_list = IsolatedCopy(security_details_.san_list);
   data->security_details_.issuer = security_details_.issuer.IsolatedCopy();
   data->security_details_.valid_from = security_details_.valid_from;
   data->security_details_.valid_to = security_details_.valid_to;
   for (auto& cert : security_details_.certificate)
     data->certificate_.push_back(cert.GetString().IsolatedCopy());
   data->security_details_.sct_list = IsolatedCopy(security_details_.sct_list);
   data->http_version_ = http_version_;
   data->app_cache_id_ = app_cache_id_;
   data->app_cache_manifest_url_ = app_cache_manifest_url_.Copy();
   data->multipart_boundary_ = multipart_boundary_;
-  data->was_fetched_via_spdy_ = was_fetched_via_spdy_;
-  data->was_fetched_via_proxy_ = was_fetched_via_proxy_;
-  data->was_fetched_via_service_worker_ = was_fetched_via_service_worker_;
-  data->was_fetched_via_foreign_fetch_ = was_fetched_via_foreign_fetch_;
-  data->was_fallback_required_by_service_worker_ =
-      was_fallback_required_by_service_worker_;
-  data->service_worker_response_type_ = service_worker_response_type_;
   data->url_list_via_service_worker_.resize(
       url_list_via_service_worker_.size());
   std::transform(url_list_via_service_worker_.begin(),
                  url_list_via_service_worker_.end(),
                  data->url_list_via_service_worker_.begin(),
                  [](const KURL& url) { return url.Copy(); });
   data->cache_storage_cache_name_ = CacheStorageCacheName().IsolatedCopy();
-  data->did_service_worker_navigation_preload_ =
-      did_service_worker_navigation_preload_;
   data->response_time_ = response_time_;
-  data->remote_ip_address_ = remote_ip_address_.GetString().IsolatedCopy();
-  data->remote_port_ = remote_port_;
   data->encoded_data_length_ = encoded_data_length_;
   data->encoded_body_length_ = encoded_body_length_;
   data->decoded_body_length_ = decoded_body_length_;
   data->downloaded_file_path_ = downloaded_file_path_.IsolatedCopy();
   data->downloaded_file_handle_ = downloaded_file_handle_;
 
   // Bug https://bugs.webkit.org/show_bug.cgi?id=60397 this doesn't support
   // whatever values may be present in the opaque m_extraData structure.
 
   return data;
@@ skipping 358 matching lines @@
   if (a.GetResourceLoadTiming() != b.GetResourceLoadTiming())
     return false;
   if (a.EncodedBodyLength() != b.EncodedBodyLength())
     return false;
   if (a.DecodedBodyLength() != b.DecodedBodyLength())
     return false;
   return true;
 }
 
 }  // namespace blink