Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 292063003: usrsctp: Filter out Chrome's WINVER macros to avoid -Wmacro-redefined (Closed)

Created:
6 years, 7 months ago by Reid Kleckner
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

usrsctp: Filter out Chrome's WINVER macros to avoid -Wmacro-redefined R=ronghuawu@chromium.org BUG=82385 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273990

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/usrsctp/usrsctp.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Reid Kleckner
6 years, 7 months ago (2014-05-20 01:01:34 UTC) #1
Reid Kleckner
ping?
6 years, 6 months ago (2014-05-29 17:40:14 UTC) #2
Reid Kleckner
+more reviewers
6 years, 6 months ago (2014-05-29 17:40:39 UTC) #3
ldixon
On 2014/05/29 17:40:39, Reid Kleckner wrote: > +more reviewers lgtm
6 years, 6 months ago (2014-05-29 19:48:46 UTC) #4
Reid Kleckner
The CQ bit was checked by rnk@chromium.org
6 years, 6 months ago (2014-05-29 19:51:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/292063003/1
6 years, 6 months ago (2014-05-29 19:54:50 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 19:54:52 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-05-29 19:54:52 UTC) #8
Ronghua Wu (Left Chromium)
lgtm
6 years, 6 months ago (2014-05-30 16:44:12 UTC) #9
Reid Kleckner
The CQ bit was checked by rnk@chromium.org
6 years, 6 months ago (2014-05-30 17:30:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/292063003/1
6 years, 6 months ago (2014-05-30 17:31:42 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 23:39:17 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 02:02:48 UTC) #13
Message was sent while issue was closed.
Change committed as 273990

Powered by Google App Engine
This is Rietveld 408576698