runtime/observatory/lib/src/repositories/sample_profile.dart - Issue 2920603003: Fix some observatory analysis issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/repositories/sample_profile.dart

Issue 2920603003: Fix some observatory analysis issues. (Closed)

Patch Set: rebase obs analysis issues PR against master Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/repositories/sample_profile.dart

diff --git a/runtime/observatory/lib/src/repositories/sample_profile.dart b/runtime/observatory/lib/src/repositories/sample_profile.dart

index 02d0f609d40d650055347d7e8a3770a9651c51d6..f2b6ee2f3cb8bfb3aa8f1acbe569c405c32fd8e2 100644

--- a/runtime/observatory/lib/src/repositories/sample_profile.dart

+++ b/runtime/observatory/lib/src/repositories/sample_profile.dart

@@ -70,7 +70,6 @@ class SampleProfileLoadingProgress extends M.SampleProfileLoadingProgress {

.invokeRpc('_getCpuProfile', {'tags': _tagToString(tag)});

} else if (type == M.SampleProfileType.memory) {

assert(owner is M.VM);

- M.VM vm = owner as M.VM;

response = await owner.invokeRpc(

'_getNativeAllocationSamples', {'tags': _tagToString(tag)});

} else {