Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: runtime/observatory/lib/object_graph.dart

Issue 2920603003: Fix some observatory analysis issues. (Closed)
Patch Set: rebase obs analysis issues PR against master Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/HACKING.md ('k') | runtime/observatory/lib/src/cpu_profile/cpu_profile.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/object_graph.dart
diff --git a/runtime/observatory/lib/object_graph.dart b/runtime/observatory/lib/object_graph.dart
index 324f14fe59cac75f20572984307663afdfae9e05..324654ca0612bb23d720e663663d044972de623d 100644
--- a/runtime/observatory/lib/object_graph.dart
+++ b/runtime/observatory/lib/object_graph.dart
@@ -915,7 +915,6 @@ class ObjectGraph {
}
void _calculateRetainedSizes() {
- var N = _N;
var Nconnected = _Nconnected;
var size = 0;
@@ -1052,7 +1051,6 @@ class ObjectGraph {
if (next[parent1] == end) return;
// Find the middle of the list.
- int cid = cids[parent1];
int slow = parent1;
int fast = parent1;
while (next[fast] != end && next[next[fast]] != end) {
@@ -1083,7 +1081,6 @@ class ObjectGraph {
while (workStackTop > 0) {
var parent = workStack[--workStackTop];
- var prev = SENTINEL;
var child = head[parent];
while (child != SENTINEL) {
// Push child.
« no previous file with comments | « runtime/observatory/HACKING.md ('k') | runtime/observatory/lib/src/cpu_profile/cpu_profile.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698