Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: runtime/observatory/tests/service/evaluate_activation_in_method_class_test.dart

Issue 2920603003: Fix some observatory analysis issues. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/evaluate_activation_in_method_class_test.dart
diff --git a/runtime/observatory/tests/service/evaluate_activation_in_method_class_test.dart b/runtime/observatory/tests/service/evaluate_activation_in_method_class_test.dart
index 6f1f72731ef51d852fd7bf641cc13c9624a83cbe..daef8d0a3d341c03f273f7b60669776e54810a12 100644
--- a/runtime/observatory/tests/service/evaluate_activation_in_method_class_test.dart
+++ b/runtime/observatory/tests/service/evaluate_activation_in_method_class_test.dart
@@ -15,6 +15,7 @@ import 'evaluate_activation_in_method_class_other.dart';
var topLevel = "TestLibrary";
+// ignore: mixin_inherits_from_not_object
siva 2017/06/01 19:26:33 Not sure what this comment here means?
rmacnak 2017/06/01 19:30:46 If the analyzer produces an error here, that is a
devoncarew 2017/06/01 20:11:54 It does report an issue; I believe it is correct i
rmacnak 2017/06/05 16:33:50 Mixing-in a class that extends not-Object is allow
class Subclass extends Superclass with Klass {
var _instVar = 'Subclass';
var instVar = 'Subclass';

Powered by Google App Engine
This is Rietveld 408576698