Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2891)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 2920603003: Fix some observatory analysis issues. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index 2fa3ff4d9c06860c92c265e88af400fbff3f7439..1d3c55b2c6857ec203e448f4476d8f91ee6cd526 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -518,7 +518,6 @@ class InspectPage extends MatchingPage {
_reachableSizeRepository,
_inboundReferencesRepository,
_retainingPathRepository,
siva 2017/06/01 19:26:32 why remove _objectRepository? The factory construc
devoncarew 2017/06/01 20:11:54 This is creating a ObjectViewElement (not a Object
siva 2017/06/01 21:28:07 Ah ok, ObjectPoolViewElement was created above.
- _objectRepository,
queue: app.queue)
];
} else if (obj is Sentinel) {

Powered by Google App Engine
This is Rietveld 408576698