Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Side by Side Diff: runtime/observatory/lib/src/elements/isolate_view.dart

Issue 2920603003: Fix some observatory analysis issues. (Closed)
Patch Set: rebase obs analysis issues PR against master Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library isolate_view_element; 5 library isolate_view_element;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:html'; 8 import 'dart:html';
9 import 'package:observatory/models.dart' as M; 9 import 'package:observatory/models.dart' as M;
10 import 'package:observatory/src/elements/curly_block.dart'; 10 import 'package:observatory/src/elements/curly_block.dart';
(...skipping 346 matching lines...) Expand 10 before | Expand all | Expand 10 after
357 queue: _r.queue) 357 queue: _r.queue)
358 ] 358 ]
359 : const [], 359 : const [],
360 new HRElement(), 360 new HRElement(),
361 new ViewFooterElement(queue: _r.queue) 361 new ViewFooterElement(queue: _r.queue)
362 ] 362 ]
363 ]; 363 ];
364 } 364 }
365 365
366 DivElement _populateThreadInfo(M.Thread t) { 366 DivElement _populateThreadInfo(M.Thread t) {
367 int index = 0;
368 return new DivElement() 367 return new DivElement()
369 ..classes = ['indent'] 368 ..classes = ['indent']
370 ..children = [ 369 ..children = [
371 new SpanElement()..text = '${t.id} ', 370 new SpanElement()..text = '${t.id} ',
372 new CurlyBlockElement(queue: _r.queue) 371 new CurlyBlockElement(queue: _r.queue)
373 ..content = [ 372 ..content = [
374 new DivElement() 373 new DivElement()
375 ..classes = ['indent'] 374 ..classes = ['indent']
376 ..text = 'kind ${t.kindString}', 375 ..text = 'kind ${t.kindString}',
377 new DivElement() 376 new DivElement()
(...skipping 18 matching lines...) Expand all
396 _function = await _functions.get(_isolate, frame.function.id); 395 _function = await _functions.get(_isolate, frame.function.id);
397 } 396 }
398 if (_isolate.rootLibrary != null) { 397 if (_isolate.rootLibrary != null) {
399 final rootLibrary = 398 final rootLibrary =
400 await _libraries.get(_isolate, _isolate.rootLibrary.id); 399 await _libraries.get(_isolate, _isolate.rootLibrary.id);
401 _rootScript = rootLibrary.rootScript; 400 _rootScript = rootLibrary.rootScript;
402 } 401 }
403 _r.dirty(); 402 _r.dirty();
404 } 403 }
405 } 404 }
OLDNEW
« no previous file with comments | « runtime/observatory/lib/src/elements/instance_ref.dart ('k') | runtime/observatory/lib/src/repositories/sample_profile.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698