Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: runtime/observatory/lib/src/elements/debugger.dart

Issue 2920603003: Fix some observatory analysis issues. (Closed)
Patch Set: rebase obs analysis issues PR against master Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library debugger_page_element; 5 library debugger_page_element;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:svg'; 8 import 'dart:svg';
9 import 'dart:html'; 9 import 'dart:html';
10 import 'dart:math'; 10 import 'dart:math';
(...skipping 424 matching lines...) Expand 10 before | Expand all | Expand 10 after
435 '\n' 435 '\n'
436 'Syntax: rewind\n' 436 'Syntax: rewind\n'
437 ' rewind <count>\n'; 437 ' rewind <count>\n';
438 } 438 }
439 439
440 class ReloadCommand extends DebuggerCommand { 440 class ReloadCommand extends DebuggerCommand {
441 ReloadCommand(Debugger debugger) : super(debugger, 'reload', []); 441 ReloadCommand(Debugger debugger) : super(debugger, 'reload', []);
442 442
443 Future run(List<String> args) async { 443 Future run(List<String> args) async {
444 try { 444 try {
445 int count = 1;
446 if (args.length > 0) { 445 if (args.length > 0) {
447 debugger.console.print('reload expects no arguments'); 446 debugger.console.print('reload expects no arguments');
448 return; 447 return;
449 } 448 }
450 await debugger.isolate.reloadSources(); 449 await debugger.isolate.reloadSources();
451 debugger.console.print('reload complete'); 450 debugger.console.print('reload complete');
452 await debugger.refreshStack(); 451 await debugger.refreshStack();
453 } on S.ServerRpcException catch (e) { 452 } on S.ServerRpcException catch (e) {
454 if (e.code == S.ServerRpcException.kIsolateReloadBarred || 453 if (e.code == S.ServerRpcException.kIsolateReloadBarred ||
455 e.code == S.ServerRpcException.kIsolateIsReloading) { 454 e.code == S.ServerRpcException.kIsolateIsReloading) {
(...skipping 2887 matching lines...) Expand 10 before | Expand all | Expand 10 after
3343 ..setAttribute('height', '24') 3342 ..setAttribute('height', '24')
3344 ..children = [ 3343 ..children = [
3345 new PathElement() 3344 new PathElement()
3346 ..setAttribute( 3345 ..setAttribute(
3347 'd', 3346 'd',
3348 'M11 17h2v-6h-2v6zm1-15C6.48 2 2 6.48 2 12s4.48 10 ' 3347 'M11 17h2v-6h-2v6zm1-15C6.48 2 2 6.48 2 12s4.48 10 '
3349 '10 10 10-4.48 10-10S17.52 2 12 2zm0 18c-4.41 ' 3348 '10 10 10-4.48 10-10S17.52 2 12 2zm0 18c-4.41 '
3350 '0-8-3.59-8-8s3.59-8 8-8 8 3.59 8 8-3.59 8-8 8zM11 ' 3349 '0-8-3.59-8-8s3.59-8 8-8 8 3.59 8 8-3.59 8-8 8zM11 '
3351 '9h2V7h-2v2z') 3350 '9h2V7h-2v2z')
3352 ]; 3351 ];
OLDNEW
« no previous file with comments | « runtime/observatory/lib/src/cpu_profile/cpu_profile.dart ('k') | runtime/observatory/lib/src/elements/instance_ref.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698