Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js

Issue 2920593002: Print Preview: Migrate remaining JS tests to use Mocha. (Closed)
Patch Set: Address comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/webui/print_preview/print_preview_tests.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js
diff --git a/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js b/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js
index 740c11aeb797a5178fede4318f5ab2cd0a8c46d4..ef6c93204d077671c55ba7c7448cf054248f3f82 100644
--- a/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js
+++ b/chrome/test/data/webui/print_preview/print_preview_ui_browsertest.js
@@ -25,7 +25,7 @@ PrintPreviewUIBrowserTest.prototype = {
runAccessibilityChecks: true,
/** @override */
- accessibilityIssuesAreErrors: false,
+ accessibilityIssuesAreErrors: true,
/** @override */
isAsync: true,
@@ -82,15 +82,35 @@ PrintPreviewUIBrowserTest.prototype = {
'ZeroTopAndBottomMarginsHideHeaderFooter',
'ZeroTopAndNonZeroBottomMarginShowHeaderFooter',
'SmallPaperSizeHeaderFooter',
- 'TestColorSettingsMonochrome',
- 'TestColorSettingsCustomMonochrome',
- 'TestColorSettingsColor',
- 'TestColorSettingsCustomColor',
- 'TestColorSettingsBothStandardDefaultColor',
- 'TestColorSettingsBothStandardDefaultMonochrome',
- 'TestColorSettingsBothCustomDefaultColor',
+ 'ColorSettingsMonochrome',
+ 'ColorSettingsCustomMonochrome',
+ 'ColorSettingsColor',
+ 'ColorSettingsCustomColor',
+ 'ColorSettingsBothStandardDefaultColor',
+ 'ColorSettingsBothStandardDefaultMonochrome',
+ 'ColorSettingsBothCustomDefaultColor',
+ 'DuplexSettingsTrue',
+ 'DuplexSettingsFalse',
+ 'PrinterChangeUpdatesPreview',
+ 'NoPDFPluginErrorMessage',
+ 'CustomPaperNames',
+ 'InitIssuesOneRequest',
+ 'InvalidSettingsError',
+ 'GenerateDraft',
].forEach(function(testName) {
TEST_F('PrintPreviewUIBrowserTest', testName, function() {
mocha.grep(new RegExp(testName + '\\b')).run();
});
});
+
+
+// Disable accessibility errors for some tests.
+[
+ 'AdvancedSettings1Option',
+ 'AdvancedSettings2Options',
+].forEach(function(testName) {
+ TEST_F('PrintPreviewUIBrowserTest', testName, function() {
+ this.accessibilityIssuesAreErrors = false;
+ mocha.grep(new RegExp(testName + '\\b')).run();
+ });
+});
« no previous file with comments | « chrome/test/data/webui/print_preview/print_preview_tests.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698