Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2920563002: Replace modelled Dart code comments with Kernel text validation. (Closed)

Created:
3 years, 6 months ago by scheglov
Modified:
3 years, 6 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace modelled Dart code comments with Kernel text validation. Paul, do you want to keep ASCII hierarchies, or the text provides enough information / easy to read? R=ahe@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/463275881d3dfd9b1a33c3e0d51b74d8938c1188

Patch Set 1 #

Patch Set 2 : Remove ASCII class hierarchies in comments. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -133 lines) Patch
M pkg/kernel/test/class_hierarchy_test.dart View 1 31 chunks +177 lines, -133 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 6 months ago (2017-05-31 19:14:56 UTC) #1
Paul Berry
lgtm I'm fine removing the comments.
3 years, 6 months ago (2017-05-31 19:36:40 UTC) #2
scheglov
Committed patchset #2 (id:20001) manually as 463275881d3dfd9b1a33c3e0d51b74d8938c1188 (presubmit successful).
3 years, 6 months ago (2017-05-31 20:09:43 UTC) #4
ahe
3 years, 6 months ago (2017-06-01 13:59:18 UTC) #5
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/2920563002/diff/20001/pkg/kernel/test/class_h...
File pkg/kernel/test/class_hierarchy_test.dart (right):

https://codereview.chromium.org/2920563002/diff/20001/pkg/kernel/test/class_h...
pkg/kernel/test/class_hierarchy_test.dart:368: class F implements
self::D<core::int, core::bool> {}
In this case, I find the code more helpful than the diagram. When I was first
looking at this, I got stumped by the test on line 387.

Powered by Google App Engine
This is Rietveld 408576698