Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Unified Diff: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h

Issue 2920373003: [ActiveSuggestionMarker #4] Refactor InlineTextBoxPainter to avoid using CompositionUnderline (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h
diff --git a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h
index 9b808710bb8fb39def4f495a3f98ec309a383964..814f35f44d068551aed2a20ba4437912ee05b8ea 100644
--- a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h
+++ b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h
@@ -14,7 +14,6 @@ namespace blink {
struct PaintInfo;
class Color;
-class CompositionUnderline;
class ComputedStyle;
class DocumentMarker;
class Font;
@@ -23,6 +22,7 @@ class InlineTextBox;
class LayoutObject;
class LayoutPoint;
class LayoutTextCombine;
+class StyleableMarker;
class TextMatchMarker;
enum class DocumentMarkerPaintPhase { kForeground, kBackground };
@@ -62,13 +62,13 @@ class InlineTextBoxPainter {
private:
enum class PaintOptions { kNormal, kCombinedText };
- void PaintSingleCompositionBackgroundRun(GraphicsContext&,
- const LayoutPoint& box_origin,
- const ComputedStyle&,
- const Font&,
- Color background_color,
- int start_pos,
- int end_pos);
+ void PaintSingleMarkerBackgroundRun(GraphicsContext&,
+ const LayoutPoint& box_origin,
+ const ComputedStyle&,
+ const Font&,
+ Color background_color,
+ int start_pos,
+ int end_pos);
template <PaintOptions>
void PaintSelection(GraphicsContext&,
const LayoutRect& box_rect,
@@ -77,11 +77,11 @@ class InlineTextBoxPainter {
Color text_color,
LayoutTextCombine* = nullptr);
- void PaintCompositionUnderline(GraphicsContext&,
- const LayoutPoint& box_origin,
- const CompositionUnderline&);
- unsigned UnderlinePaintStart(const CompositionUnderline&);
- unsigned UnderlinePaintEnd(const CompositionUnderline&);
+ void PaintStyleableMarkerUnderline(GraphicsContext&,
+ const LayoutPoint& box_origin,
+ const StyleableMarker&);
+ unsigned MarkerPaintStart(const DocumentMarker&);
+ unsigned MarkerPaintEnd(const DocumentMarker&);
bool ShouldPaintTextBox(const PaintInfo&);
void ExpandToIncludeNewlineForSelection(LayoutRect&);
LayoutObject& InlineLayoutObject() const;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698