Issue 2920333002: Remove an analysis server import.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2920333002: Remove an analysis server import. (Closed)

Created:
3 years, 6 months ago by devoncarew

Modified:
3 years, 6 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	pkg/analyzer/lib/source/pub_package_map_provider.dart	View		2 chunks	+1 line, -4 lines	0 comments	Download

Total messages: 6 (2 generated)

devoncarew

Remove an analysis server import. I believe that _runPubList() is rarely (never?) called in practice, ...

3 years, 6 months ago (2017-06-05 18:08:45 UTC) #2

Brian Wilkerson

lgtm I believe that it should never be run, but I'm not sure it isn't ...

3 years, 6 months ago (2017-06-05 18:21:01 UTC) #3

devoncarew

3 years, 6 months ago (2017-06-05 18:22:58 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
24b112d865199f9f55b5c5331759f5ff4a605528 (presubmit successful).