Issue 292023002: Ensure that the class is finalized before marking class as having

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 292023002: Ensure that the class is finalized before marking class as having (Closed)

Created:
6 years, 7 months ago by siva

Modified:
6 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Ensure that the class is finalized before marking class as having nullable fields. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36339

Patch Set 1 #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	runtime/vm/dart_api_impl.cc	View		2 chunks	+7 lines, -5 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/292023002/diff/1/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/292023002/diff/1/runtime/vm/dart_api_impl.cc#newcode3284 runtime/vm/dart_api_impl.cc:3284: ASSERT(iterate_cls.is_finalized()); Strictly, this is not necessary since all ...

6 years, 7 months ago (2014-05-19 23:39:10 UTC) #2

siva

Thanks. https://codereview.chromium.org/292023002/diff/1/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/292023002/diff/1/runtime/vm/dart_api_impl.cc#newcode3284 runtime/vm/dart_api_impl.cc:3284: ASSERT(iterate_cls.is_finalized()); Agreed but I was just being extra ...

6 years, 7 months ago (2014-05-19 23:42:16 UTC) #3

siva

6 years, 7 months ago (2014-05-19 23:48:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r36339 (presubmit successful).

Expand Messages | Collapse Messages