Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2920223008: Record method invocation targets that are not procedures. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Record method invocation targets that are not procedures. We don't yet store the targets in the kernel representation, since kernel currently requires method invocation targets to be procedures (see https://codereview.chromium.org/2923653003/). But we record the target that we *would* store in the kernel to instrumentation so that we can pass tests. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/32e78868bd369913ccf53b76db2527a78cacbb2a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -29 lines) Patch
M pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 2 chunks +13 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 1 chunk +1 line, -1 line 1 comment Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +12 lines, -5 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 3 chunks +0 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_list_literals_infer_if_value_types_match_context.dart View 5 chunks +8 lines, -6 lines 0 comments Download
A pkg/front_end/testcases/inference/downwards_inference_on_list_literals_infer_if_value_types_match_context.dart.strong.expect View 1 chunk +61 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_downwards_generic_method_with_future_return.dart View 1 chunk +2 lines, -3 lines 0 comments Download
A pkg/front_end/testcases/inference/future_union_downwards_generic_method_with_future_return.dart.strong.expect View 1 chunk +40 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/future_union_upwards_generic_methods.dart View 1 chunk +3 lines, -5 lines 0 comments Download
A pkg/front_end/testcases/inference/future_union_upwards_generic_methods.dart.strong.expect View 1 chunk +55 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_methods_iterable_and_future.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_cascade.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/method_call_with_type_arguments_static_method.dart View 1 chunk +3 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/method_call_with_type_arguments_static_method.dart.strong.expect View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Paul Berry
3 years, 6 months ago (2017-06-06 18:10:37 UTC) #2
Paul Berry
Adding Peter since he appears to still be up, and Konstantin isn't around
3 years, 6 months ago (2017-06-06 18:58:31 UTC) #4
ahe
lgtm https://codereview.chromium.org/2920223008/diff/1/pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart File pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart (right): https://codereview.chromium.org/2920223008/diff/1/pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart#newcode319 pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart:319: offsetForToken(send.token)); I saw some messages earlier today that ...
3 years, 6 months ago (2017-06-06 19:13:59 UTC) #5
Paul Berry
Committed patchset #1 (id:1) manually as 32e78868bd369913ccf53b76db2527a78cacbb2a (presubmit successful).
3 years, 6 months ago (2017-06-06 19:27:38 UTC) #7
scheglov
3 years, 6 months ago (2017-06-06 19:47:25 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698