Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2920223002: Add additional histograms with suffixes to ImportantFileWriter. (Closed)
Patch Set: Fix more problems pointed by code reviewers. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« base/files/important_file_writer.cc ('K') | « components/feedback/feedback_report.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index f6fba527f5cb13cf7106ad60076529ad94bb2a05..8f14bdcfddd5b616cd303cc2280c4f3176ed230b 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -24697,6 +24697,42 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="ImportantFile.FileCreateError" enum="PlatformFileError">
+ <owner>xaerox@yandex-team.ru</owner>
+ <summary>
+ File error happened upon temporary file creation at ImportantFileWriter.
+ </summary>
+</histogram>
+
+<histogram name="ImportantFile.FileDeleteError" enum="PlatformFileError">
+ <owner>xaerox@yandex-team.ru</owner>
+ <summary>
+ File error happened upon temporary file deletion at ImportantFileWriter.
+ </summary>
+</histogram>
+
+<histogram name="ImportantFile.FileOpenError" enum="PlatformFileError">
+ <owner>xaerox@yandex-team.ru</owner>
+ <summary>
+ File error happened upon opening temporary file at ImportantFileWriter.
+ </summary>
+</histogram>
+
+<histogram name="ImportantFile.FileRenameError" enum="PlatformFileError">
+ <owner>xaerox@yandex-team.ru</owner>
+ <summary>
+ File error happened upon temporary file renaming at ImportantFileWriter.
+ </summary>
+</histogram>
+
+<histogram name="ImportantFile.FileWriteError" enum="PlatformFileError">
+ <owner>xaerox@yandex-team.ru</owner>
+ <summary>
+ File error happened upon writing data to temporary file at
+ ImportantFileWriter.
+ </summary>
+</histogram>
+
<histogram name="ImportantFile.TempFileFailures" enum="TempFileFailure">
<owner>rvargas@chromium.org</owner>
<summary>
@@ -88594,6 +88630,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<affected-histogram name="PageLoad.Timing2.NavigationToFirstContentfulPaint"/>
</histogram_suffixes>
+<histogram_suffixes name="ImportantFileWriterSuffix" separator=".">
+ <suffix name="BookmarkStorage"/>
+ <suffix name="FeedbackReport"/>
+ <affected-histogram name="ImportantFile.FileCreateError"/>
+ <affected-histogram name="ImportantFile.FileDeleteError"/>
+ <affected-histogram name="ImportantFile.FileOpenError"/>
+ <affected-histogram name="ImportantFile.FileRenameError"/>
+ <affected-histogram name="ImportantFile.FileWriteError"/>
+ <affected-histogram name="ImportantFile.TempFileFailures"/>
+</histogram_suffixes>
+
<histogram_suffixes name="IndexedDBLevelDBErrnoMethods" separator=".">
<suffix name="NewLogger" label="ChromiumEnv::NewLogger"/>
<suffix name="NewSequentialFile" label="ChromiumEnv::NewSequentialFile"/>
« base/files/important_file_writer.cc ('K') | « components/feedback/feedback_report.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698