Add additional histograms with suffixes to ImportantFileWriter.

base/files/important_file_writer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_FILES_IMPORTANT_FILE_WRITER_H_
 #define BASE_FILES_IMPORTANT_FILE_WRITER_H_
 
 #include <string>
 
 #include "base/base_export.h"
@@ skipping 35 matching lines @@
     // ImportantFileWriter has been created.
     virtual bool SerializeData(std::string* data) = 0;
 
    protected:
     virtual ~DataSerializer() {}
   };
 
   // Save |data| to |path| in an atomic manner. Blocks and writes data on the
   // current thread. Does not guarantee file integrity across system crash (see
   // the class comment above).
-  static bool WriteFileAtomically(const FilePath& path, StringPiece data);
+  static bool WriteFileAtomically(const FilePath& path,
+                                  StringPiece data,
+                                  std::string histogram_suffix = std::string());

[sky, 2017/06/05 16:50:33]

const std::string& on all of these.

[dcheng, 2017/06/05 18:23:59]

Or maybe just pass as const char* since it's always a literal, so we can avoid
creating the string temporary at all hopfeully.

[xaerox, 2017/06/07 09:32:54]

Acknowledged.

 
   // Initialize the writer.
   // |path| is the name of file to write.
   // |task_runner| is the SequencedTaskRunner instance where on which we will
   // execute file I/O operations.
   // All non-const methods, ctor and dtor must be called on the same thread.
   ImportantFileWriter(const FilePath& path,
-                      scoped_refptr<SequencedTaskRunner> task_runner);
+                      scoped_refptr<SequencedTaskRunner> task_runner,
+                      std::string histogram_suffix = std::string());
 
   // Same as above, but with a custom commit interval.
   ImportantFileWriter(const FilePath& path,
                       scoped_refptr<SequencedTaskRunner> task_runner,
-                      TimeDelta interval);
+                      TimeDelta interval,
+                      std::string histogram_suffix = std::string());
 
   // You have to ensure that there are no pending writes at the moment
   // of destruction.
   ~ImportantFileWriter();
 
   const FilePath& path() const { return path_; }
 
   // Returns true if there is a scheduled write pending which has not yet
   // been started.
   bool HasPendingWrite() const;
@@ skipping 56 matching lines @@
 
   // An override for |timer_| used for testing.
   Timer* timer_override_ = nullptr;
 
   // Serializer which will provide the data to be saved.
   DataSerializer* serializer_;
 
   // Time delta after which scheduled data will be written to disk.
   const TimeDelta commit_interval_;
 
+  // Custom histogram suffix.
+  std::string histogram_suffix_;

[sky, 2017/06/05 16:50:33]

const

[xaerox, 2017/06/07 09:32:54]

Acknowledged.

+
   SEQUENCE_CHECKER(sequence_checker_);
 
   WeakPtrFactory<ImportantFileWriter> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ImportantFileWriter);
 };
 
 }  // namespace base
 
 #endif  // BASE_FILES_IMPORTANT_FILE_WRITER_H_