Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 292009: Some more test_expectations.txt cleanup. Remove some consistently passing ... (Closed)

Created:
11 years, 2 months ago by Stephen White
Modified:
9 years, 7 months ago
Reviewers:
dglazkov, ojan
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

Some more test_expectations.txt cleanup. Remove some consistently passing tests (at least one of which I know was fixed upstream), record some more flakiness and crashiness. BUG=7465, 10311, 17499, 23498, 24121, 24182, 24865 TEST=green bots TBR=dglazkov Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29372

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -27 lines) Patch
M webkit/tools/layout_tests/test_expectations.txt View 14 chunks +16 lines, -27 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
ojan
http://codereview.chromium.org/292009/diff/1/2 File webkit/tools/layout_tests/test_expectations.txt (right): http://codereview.chromium.org/292009/diff/1/2#newcode2546 Line 2546: BUG9798 : LayoutTests/fast/frames/frame-limit.html = CRASH PASS TIMEOUT This ...
11 years, 2 months ago (2009-10-19 17:05:58 UTC) #1
Stephen White
11 years, 2 months ago (2009-10-19 18:51:28 UTC) #2
On 2009/10/19 17:05:58, ojan wrote:
> http://codereview.chromium.org/292009/diff/1/2
> File webkit/tools/layout_tests/test_expectations.txt (right):
> 
> http://codereview.chromium.org/292009/diff/1/2#newcode2546
> Line 2546: BUG9798 : LayoutTests/fast/frames/frame-limit.html = CRASH PASS
> TIMEOUT
> This and line 121 are not right. This should be:
> 
> BUG9798 SLOW : LayoutTests/fast/frames/frame-limit.html = CRASH PASS
> 
> Note that the test only started timing out after you committed this change.

Whoops, sorry 'bout that.  I see you've already fixed it; thanks.

BTW, in case you're curious (I was), this test opens 150 iframes, closes them,
then opens them again.  We seem to be pretty slow at that...

Powered by Google App Engine
This is Rietveld 408576698