Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: components/offline_pages/core/prefetch/prefetch_types.h

Issue 2920083002: Prefetching: Introduce store commands abstractions to be used by tasks. (Closed)
Patch Set: Added TODO for NWake Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/prefetch/prefetch_types.h
diff --git a/components/offline_pages/core/prefetch/prefetch_types.h b/components/offline_pages/core/prefetch/prefetch_types.h
index 80208f0abe8a5b0931ceb92f90d52aa7a2b4563f..0cf17584ef96c9d8ad69458466d6a6b3347bd414 100644
--- a/components/offline_pages/core/prefetch/prefetch_types.h
+++ b/components/offline_pages/core/prefetch/prefetch_types.h
@@ -108,15 +108,15 @@ using PrefetchRequestFinishedCallback =
base::Callback<void(PrefetchRequestStatus status,
const std::vector<RenderPageInfo>& pages)>;
-// Holds information about a new URL to be prefetched.
+// Holds information about a suggested URL to be prefetched.
struct PrefetchURL {
- PrefetchURL(const ClientId& client_id, const GURL& url)
- : client_id(client_id), url(url) {}
+ PrefetchURL(const std::string& id, const GURL& url) : id(id), url(url) {}
- // Client provided ID to allow the matching of URLs to the respective work
- // item in the prefetching system. It can be anything useful to identify the
- // page . It will not be used internally for de-duplication.
- ClientId client_id;
+ // Client provided ID to allow the matching of provided URLs to the respective
+ // work item in the prefetching system within that client's assigned
+ // namespace. It can be any string value and it will not be used internally
+ // for de-duplication.
+ std::string id;
// This URL will be prefetched by the service.
GURL url;

Powered by Google App Engine
This is Rietveld 408576698