Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 292008: Fix ProfileSyncService unit test. (Closed)

Created:
11 years, 2 months ago by ncarter (slow)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix ProfileSyncService unit test. Create TestHttpBridge for use by ProfileSyncServiceUnittest, so it doesn't crash. DoInitialize has been changed to take a HttpPostProviderFactory before the core initialization. The HttpBridge is now created on the UI thread instead of the core thread. Create fake tagged nodes in the order that they are requested. Make the request order consistent and in visual order since this is the most natural way to request them. TEST=Ran the affected unit tests on Windows, tested basic sync functionality with two concurrent browsers. BUG=25021 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29368

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -91 lines) Patch
M chrome/browser/sync/glue/http_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/model_associator.h View 5 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/sync/glue/model_associator.cc View 7 chunks +22 lines, -23 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.h View 7 chunks +17 lines, -19 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 4 chunks +9 lines, -22 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 4 chunks +17 lines, -7 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +1 line, -5 lines 0 comments Download
A chrome/test/sync/test_http_bridge_factory.h View 1 chunk +69 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698