Chromium Code Reviews

Unified Diff: src/isolate.h

Issue 2919953003: Clean up issues raised on previous CL. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | src/isolate.cc » ('j') | src/isolate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.h
diff --git a/src/isolate.h b/src/isolate.h
index 1296a20b01e7e2171e74680fd01da1f9ac718bfe..92d8a387a45122a3473455b2cf0fb494e1f7d981 100644
--- a/src/isolate.h
+++ b/src/isolate.h
@@ -870,8 +870,8 @@ class Isolate {
Counters* counters() {
// Call InitializeLoggingAndCounters() if logging is needed before
// the isolate is fully initialized.
- DCHECK(counters_ != NULL);
- return counters_;
+ DCHECK(counters_shared_.get() != NULL);
Mircea Trofin 2017/06/05 15:35:11 Nit: I realize this is existing code, but DCHECK_N
kschimpf 2017/06/05 18:05:43 Done.
+ return counters_shared_.get();
}
std::shared_ptr<Counters> counters_shared() { return counters_shared_; }
RuntimeProfiler* runtime_profiler() { return runtime_profiler_; }
@@ -1430,7 +1430,6 @@ class Isolate {
RuntimeProfiler* runtime_profiler_;
CompilationCache* compilation_cache_;
std::shared_ptr<Counters> counters_shared_;
- Counters* counters_;
base::RecursiveMutex break_access_;
Logger* logger_;
StackGuard stack_guard_;
« no previous file with comments | « no previous file | src/isolate.cc » ('j') | src/isolate.cc » ('J')

Powered by Google App Engine