Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6699)

Unified Diff: chrome/browser/resources/settings/site_settings/site_list.js

Issue 2919853002: [MD settings] site exceptions, use embedding origin rather than embeddingDisplayName (Closed)
Patch Set: review changes Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/site_list.js
diff --git a/chrome/browser/resources/settings/site_settings/site_list.js b/chrome/browser/resources/settings/site_settings/site_list.js
index eb5290fe4f649b6dd297fa0d828329e9080b5991..8fe62c55f76c4e45078f57044044c1238debb1aa 100644
--- a/chrome/browser/resources/settings/site_settings/site_list.js
+++ b/chrome/browser/resources/settings/site_settings/site_list.js
@@ -390,14 +390,20 @@ Polymer({
* @return {string} The site description.
*/
computeSiteDescription_: function(item) {
- if (item.incognito && item.embeddingDisplayName.length > 0) {
- return loadTimeData.getStringF(
- 'embeddedIncognitoSite', item.embeddingDisplayName);
+ var displayName = '';
+ if (item.embeddingOrigin) {
+ displayName = loadTimeData.getStringF(
+ 'embeddedOnHost', this.sanitizePort(item.embeddingOrigin));
+ } else if (this.category == settings.ContentSettingsTypes.GEOLOCATION) {
+ displayName = loadTimeData.getString('embeddedOnAnyHost');
}
- if (item.incognito)
+ if (item.incognito) {
+ if (displayName.length > 0)
+ return loadTimeData.getStringF('embeddedIncognitoSite', displayName);
return loadTimeData.getString('incognitoSite');
- return item.embeddingDisplayName;
+ }
+ return displayName;
},
/**
« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/resources/settings/site_settings/site_settings_behavior.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698