Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1287)

Unified Diff: chrome/browser/resources/settings/site_settings/site_list.js

Issue 2919853002: [MD settings] site exceptions, use embedding origin rather than embeddingDisplayName (Closed)
Patch Set: re-added embedded description Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/site_list.js
diff --git a/chrome/browser/resources/settings/site_settings/site_list.js b/chrome/browser/resources/settings/site_settings/site_list.js
index e95115fe7d38cee04a54fec5227ea0b27c8c41c4..5fe5fec9e82d4b1cb2ed212eacd1ab4bca33889c 100644
--- a/chrome/browser/resources/settings/site_settings/site_list.js
+++ b/chrome/browser/resources/settings/site_settings/site_list.js
@@ -388,14 +388,20 @@ Polymer({
* @return {string} The site description.
*/
computeSiteDescription_: function(item) {
- if (item.incognito && item.embeddingDisplayName.length > 0) {
- return loadTimeData.getStringF('embeddedIncognitoSite',
- item.embeddingDisplayName);
+ var displayName = '';
+ if (item.embeddingOrigin) {
+ displayName = loadTimeData.getStringF(
+ 'embeddedOnHost', this.sanitizePort(item.embeddingOrigin));
+ } else if (this.category == settings.ContentSettingsTypes.GEOLOCATION) {
+ displayName = loadTimeData.getStringF('embeddedOnHost', '*');
msramek 2017/06/28 19:41:33 Optional: Should we have a custom string saying "e
dschuyler 2017/06/28 21:05:38 Done.
}
- if (item.incognito)
+ if (item.incognito) {
+ if (displayName.length > 0)
+ return loadTimeData.getStringF('embeddedIncognitoSite', displayName);
return loadTimeData.getString('incognitoSite');
- return item.embeddingDisplayName;
+ }
+ return displayName;
},
/**

Powered by Google App Engine
This is Rietveld 408576698