Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1244)

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2919853002: [MD settings] site exceptions, use embedding origin rather than embeddingDisplayName (Closed)
Patch Set: remove IDS reference Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
index 87c40406d8fd9b46dc50b1c5f19762d043448f79..4c59c3947fc9fc608070e9770ecb4dc0a3c67c04 100644
--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
@@ -1689,7 +1689,6 @@ void AddSiteSettingsStrings(content::WebUIDataSource* html_source,
{"cookiePlural", IDS_SETTINGS_COOKIES_PLURAL_COOKIES},
msramek 2017/06/01 23:09:59 Not related to this patchset, but this is wrong -
dschuyler 2017/06/13 20:49:25 Added Issue 732610 to track this.
msramek 2017/06/28 19:41:33 Thank you!
{"cookieServiceWorker", IDS_SETTINGS_COOKIES_SERVICE_WORKER},
{"cookieSingular", IDS_SETTINGS_COOKIES_SINGLE_COOKIE},
- {"embeddedOnHost", IDS_EXCEPTIONS_GEOLOCATION_EMBEDDED_ON_HOST},
dschuyler 2017/06/01 22:07:12 IDS_EXCEPTIONS_GEOLOCATION_EMBEDDED_ON_HOST is sti
msramek 2017/06/01 23:09:59 Acknowledged.
{"editSiteTitle", IDS_SETTINGS_EDIT_SITE_TITLE},
{"appCacheManifest", IDS_SETTINGS_COOKIES_APPLICATION_CACHE_MANIFEST_LABEL},
{"cacheStorageLastModified",

Powered by Google App Engine
This is Rietveld 408576698