Issue 2919833002: Remove the ClassHierarchy.rootClass getter.

Issue 2919833002: Remove the ClassHierarchy.rootClass getter. (Closed)

Created:
3 years, 6 months ago by scheglov

Modified:
3 years, 6 months ago

Reviewers:
ahe, Siggi Cherem (dart-lang), Kevin Millikin (Google), Paul Berry

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Remove the ClassHierarchy.rootClass getter. According to the language specification the root class is always equivalent to the Object class. R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/00f97489cfe376bc0c28e9b2f5154ce86e7d5b10

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -13 lines)			Patch
M	pkg/kernel/lib/class_hierarchy.dart	View	3 chunks	+1 line, -4 lines	0 comments	Download
M	pkg/kernel/lib/transformations/method_call.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/kernel/lib/transformations/mixin_full_resolution.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/kernel/lib/transformations/treeshaker.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/kernel/test/class_hierarchy_test.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	pkg/kernel/test/treeshaker_membench.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (1 generated)

scheglov

Committed patchset #1 (id:1) manually as 00f97489cfe376bc0c28e9b2f5154ce86e7d5b10 (presubmit successful).

3 years, 6 months ago (2017-06-01 18:56:53 UTC) #4

Message was sent while issue was closed.

lgtm

Yeah, that was a bit odd.