Chromium Code Reviews| Index: components/printing/service/public/interfaces/pdf_compositor.mojom |
| diff --git a/components/printing/service/public/interfaces/pdf_compositor.mojom b/components/printing/service/public/interfaces/pdf_compositor.mojom |
| index 67f9448d947d274099cdc2378c63d9bc321065c4..ad8b55499022ae781cea8077a48dc9c294c5652b 100644 |
| --- a/components/printing/service/public/interfaces/pdf_compositor.mojom |
| +++ b/components/printing/service/public/interfaces/pdf_compositor.mojom |
| @@ -8,9 +8,18 @@ const string kServiceName = "pdf_compositor"; |
| // TODO(weili): Add support for printing frames from different processes. |
| interface PdfCompositor { |
| + // The status of CompositePdf execution. |
| + enum Status { |
| + SUCCESS, |
| + HANDLE_MAP_ERROR, |
| + CONTENT_FORMAT_ERROR, |
| + COMPOSTING_FAILURE, |
|
Lei Zhang
2017/06/02 21:54:09
type: COMPOSITING_FAILURE
style: kCompositingFailu
Wei Li
2017/07/07 21:23:57
Both styles are ok per style guide (https://engdoc
|
| + }; |
| + |
| // Currently directly convert passed in page data to a PDF file. |
| // |sk_handle| points to a buffer of a Skia MultiPictureDocument. |
| - // |pdf_handle| points to the generated PDF file buffer. |
| + // |status| records the function execution status. |
| + // |pdf_handle| points to the generated PDF file buffer upon success. |
| CompositePdf(handle<shared_buffer> sk_handle) |
| - => (handle<shared_buffer> pdf_handle); |
| + => (Status status, handle<shared_buffer>? pdf_handle); |
| }; |