components/printing/service/DEPS - Issue 2919823004: Add error handling and unit test for pdf compositor service

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/printing/service/DEPS

Issue 2919823004: Add error handling and unit test for pdf compositor service (Closed)

Patch Set: rebase Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/discardable_memory/client",	2 "+components/discardable_memory/client",

3 "+content/public/common",	3 "+content/public/common",

4 "+content/public/utility",	4 "+content/public/utility",

5 "+mojo/public/cpp",	5 "+mojo/public/cpp",

6 "+printing/common",	6 "+printing/common",

7 "+services/service_manager/public/cpp",	7 "+services/service_manager/public/cpp",

	8 "+services/service_manager/public/c", # For tests only.
	Ken Rockot(use gerrit already) 2017/07/25 05:02:06 rather than having this comment, you could move th rather than having this comment, you could move this entry out of include_rules and into: specific_include_rules: { "service_main.cc": [ "+services/service_manager/public/c", ] } Wei Li 2017/07/26 05:08:50 Done. Show quoted text On 2017/07/25 05:02:06, Ken Rockot(use gerrit already) wrote: > rather than having this comment, you could move this entry out of include_rules > and into: > > specific_include_rules: { > "service_main.cc": [ > "+services/service_manager/public/c", > ] > } Done.
8 "+skia",	9 "+skia",

9 "+third_party/skia",	10 "+third_party/skia",

10 ]	11 ]

OLD	NEW