Detect AudioInputStream muting and propagate to MediaStreamAudioSource.

content/renderer/media/media_stream_source.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/media_stream_source.h"
 
 #include "base/callback_helpers.h"
 
 namespace content {
 
 const char MediaStreamSource::kSourceId[] = "sourceId";
 
 MediaStreamSource::MediaStreamSource() {
 }
 
 MediaStreamSource::~MediaStreamSource() {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(stop_callback_.is_null());
 }
 
 void MediaStreamSource::StopSource() {
   DCHECK(thread_checker_.CalledOnValidThread());
   DoStopSource();
   if (!stop_callback_.is_null())
     base::ResetAndReturn(&stop_callback_).Run(Owner());
   Owner().SetReadyState(blink::WebMediaStreamSource::kReadyStateEnded);
 }
 
+void MediaStreamSource::SetSourceMuted(bool is_muted) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  // TODO(ossu): Check that we only go between Muted and Live, not from Ended.

[ossu-chromium, 2017/06/01 15:56:59]

This looks like it's already be taken care of downstream, but maybe a sanity
check here would be useful?

[Max Morin, 2017/06/02 09:56:04]

Yes. Could you point out where this is taken care of?

[ossu-chromium, 2017/06/02 10:47:59]

MediaStreamTrack::SourceChangedState() checks if the current ReadyState is Ended
and just does nothing.
MediaStreamSource::SetReadyState also checks that the current ReadyState isn't
Ended before doing anything.
I could point to those in a comment. I'm wondering if a DCHECK here would be
good. We really shouldn't be sending mute/unmute notifications for a stream
that's ended, but maybe timing, threading and queuing sometimes would have that
happen? It would be sad if we crashed.

[Max Morin, 2017/06/05 07:01:38]

Right, feels better without a DCHECK.

+  Owner().SetReadyState(is_muted
+                            ? blink::WebMediaStreamSource::kReadyStateMuted
+                            : blink::WebMediaStreamSource::kReadyStateLive);
+}
+
 void MediaStreamSource::SetDeviceInfo(const StreamDeviceInfo& device_info) {
   DCHECK(thread_checker_.CalledOnValidThread());
   device_info_ = device_info;
 }
 
 void MediaStreamSource::SetStopCallback(
     const SourceStoppedCallback& stop_callback) {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(stop_callback_.is_null());
   stop_callback_ = stop_callback;
 }
 
 void MediaStreamSource::ResetSourceStoppedCallback() {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(!stop_callback_.is_null());
   stop_callback_.Reset();
 }
 
 }  // namespace content