Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: ppapi/native_client/src/trusted/plugin/pnacl_resources.h

Issue 291973002: Pepper: DescWrapper cleanup in PnaclResources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/trusted/plugin/pnacl_resources.h
diff --git a/ppapi/native_client/src/trusted/plugin/pnacl_resources.h b/ppapi/native_client/src/trusted/plugin/pnacl_resources.h
index 7cefa6f7592122d81b1535abffb6be159f4b0954..7c6e18b4baf3c1f31140cae37fb24844ebc155e2 100644
--- a/ppapi/native_client/src/trusted/plugin/pnacl_resources.h
+++ b/ppapi/native_client/src/trusted/plugin/pnacl_resources.h
@@ -46,7 +46,9 @@ class PnaclResources {
PnaclResources(Plugin* plugin,
PnaclCoordinator* coordinator)
: plugin_(plugin),
- coordinator_(coordinator) {
+ coordinator_(coordinator),
+ llc_file_handle_(PP_kInvalidFileHandle),
+ ld_file_handle_(PP_kInvalidFileHandle) {
}
virtual ~PnaclResources();
@@ -63,14 +65,8 @@ class PnaclResources {
const nacl::string& GetLlcUrl() { return llc_tool_name_; }
const nacl::string& GetLdUrl() { return ld_tool_name_; }
- nacl::string GetFullUrl(const nacl::string& partial_url,
- const nacl::string& sandbox_arch) const;
-
- // Get file descs by name. Only valid after StartLoad's completion callback
- // fired.
- nacl::DescWrapper* WrapperForUrl(const nacl::string& url);
-
- static int32_t GetPnaclFD(Plugin* plugin, const char* filename);
+ PP_FileHandle TakeLlcFileHandle();
+ PP_FileHandle TakeLdFileHandle();
private:
NACL_DISALLOW_COPY_AND_ASSIGN(PnaclResources);
@@ -79,13 +75,15 @@ class PnaclResources {
Plugin* plugin_;
// The coordinator responsible for reporting errors, etc.
PnaclCoordinator* coordinator_;
- // The descriptor wrappers for the downloaded URLs. Only valid
- // once all_loaded_callback_ has been invoked.
- std::map<nacl::string, nacl::DescWrapper*> resource_wrappers_;
// Tool names for llc and ld; read from the resource info file.
nacl::string llc_tool_name_;
nacl::string ld_tool_name_;
+
+ // File handles for llc and ld executables, after they've been opened.
+ // Only valid after the callback for StartLoad() has been called.
bbudge 2014/05/21 02:04:24 and until the Take* fns are called?
+ PP_FileHandle llc_file_handle_;
+ PP_FileHandle ld_file_handle_;
};
} // namespace plugin;

Powered by Google App Engine
This is Rietveld 408576698