Pepper: DescWrapper cleanup in PnaclResources.

Pepper: DescWrapper cleanup in PnaclResources.

This is part of an effort to get rid of use of DescWrapper/NaClDesc for nexe
module loading. This is anticipation of moving nexe loading away from SRPC to
Chrome IPC.

Note that this tightens up some permissions for converting file descriptors;
I'm not sure why some were originally opened with _O_RDWR.

BUG=333950
R=bbudge@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271918

[bbudge, 2014-05-21 02:04:24]

LGTM w / suggestions.
I'm not that familiar with some of this code, so if you're worried about
regressions you might want to ping jvoung.

https://codereview.chromium.org/291973002/diff/80001/ppapi/native_client/src/...
File ppapi/native_client/src/trusted/plugin/pnacl_resources.cc (right):

https://codereview.chromium.org/291973002/diff/80001/ppapi/native_client/src/...
ppapi/native_client/src/trusted/plugin/pnacl_resources.cc:135: //
ReadResourceInfo() should happen first, and error out.
s/happen first, and error out/fail first  ?

https://codereview.chromium.org/291973002/diff/80001/ppapi/native_client/src/...
File ppapi/native_client/src/trusted/plugin/pnacl_resources.h (right):

https://codereview.chromium.org/291973002/diff/80001/ppapi/native_client/src/...
ppapi/native_client/src/trusted/plugin/pnacl_resources.h:84: // Only valid after
the callback for StartLoad() has been called.
and until the Take* fns are called?

https://codereview.chromium.org/291973002/diff/80001/ppapi/native_client/src/...
File ppapi/native_client/src/trusted/plugin/utility.cc (right):

https://codereview.chromium.org/291973002/diff/80001/ppapi/native_client/src/...
ppapi/native_client/src/trusted/plugin/utility.cc:140: flags |= _O_RDWR;
Consider conditional expression:

flags |= read_only ? _O_RDONLY : _O_RDWR;

[teravest, 2014-05-21 14:09:56]

The CQ bit was checked by teravest@chromium.org

[teravest, 2014-05-21 15:26:41]

The CQ bit was unchecked by teravest@chromium.org

[teravest, 2014-05-21 15:26:41]

The CQ bit was checked by teravest@chromium.org

[teravest, 2014-05-21 16:59:21]

Committed patchset #2 manually as r271918 (presubmit successful).