Treat tethered networks as mobile networks

chromeos/network/network_state.h

Index: chromeos/network/network_state.h
diff --git a/chromeos/network/network_state.h b/chromeos/network/network_state.h
index d43c56273e7c02f1a7947d0889342e8f00777698..9a14ff5ee520f79e52a061f7bb5bb2ee019bed5e 100644
--- a/chromeos/network/network_state.h
+++ b/chromeos/network/network_state.h
@@ -112,6 +112,10 @@ class CHROMEOS_EXPORT NetworkState : public ManagedState {
   void set_battery_percentage(int battery_percentage) {
     battery_percentage_ = battery_percentage;
   }
+  const std::string& tethering_state() const { return tethering_state_; }
+  void set_tethering_state(std::string tethering_state) {
+    tethering_state_ = tethering_state;
+  }

[stevenjb, 2017/06/01 16:03:36]

1. We shouldn't need a setter for this.
2. "tethering" is a bit different from type=Tether networks, so let's move
tethering_state() under the 'Cellular property accessors' section.
3. Since (for now anyway) we are always checking for "type==Cellular or
tethering==confirmed", instead of thethering_state() let's add a method here
"IsUsingMobileData()" which has that logic so that it is in one place.
4. We also want to add "type==Tether" to the IsUsingMobileData() method (another
good reason to put the logic in one place).

[weidongg, 2017/06/01 18:14:29]

Aha, that's much cleaner. Thanks. BTW, does it mean that when 'Magic Tether' is
implemented, we could get 'type==Tether' instead of 'tethering==confirmed'?

[stevenjb, 2017/06/01 20:03:00]

They are different things. You can still connect to a phone hotspot without
using Magic Tether.

   const std::string& carrier() const { return carrier_; }
   void set_carrier(const std::string& carrier) { carrier_ = carrier; }
   bool tether_has_connected_to_host() const {
@@ -235,6 +239,7 @@ class CHROMEOS_EXPORT NetworkState : public ManagedState {
   // Tether properties.
   std::string carrier_;
   int battery_percentage_;
+  std::string tethering_state_;

[stevenjb, 2017/06/01 16:03:36]

Blank line here (but also move this after line 232)

[weidongg, 2017/06/01 18:14:29]

Done.

   // Whether the current device has already connected to the tether host device
   // providing the hotspot corresponding to this NetworkState.
   // Note: this means that the current device has already connected to the