third_party/WebKit/Source/core/layout/LayoutTableCell.h - Issue 2919653004: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableCell.h

Issue 2919653004: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH (Closed)

Patch Set: Use LOG() or CHECKi()|CHECK_FOO() instead of IMMEDIATE_CRASH Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTableCell.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutTableCell.h b/third_party/WebKit/Source/core/layout/LayoutTableCell.h

index c51301715749e7c696b7b1756d41ecb13cbc2729..dab75c75077f10a835ce9a56336c2e8e4f65919d 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTableCell.h

+++ b/third_party/WebKit/Source/core/layout/LayoutTableCell.h

@@ -103,9 +103,7 @@ class CORE_EXPORT LayoutTableCell final : public LayoutBlockFlow {

void ColSpanOrRowSpanChanged();

void SetAbsoluteColumnIndex(unsigned column) {

- if (UNLIKELY(column > kMaxColumnIndex))

- IMMEDIATE_CRASH();

+ CHECK(!UNLIKELY(column > kMaxColumnIndex));

tkent 2017/06/05 01:58:51 UNLIKELY isn't necessary. CHECK() contains it inte

absolute_column_index_ = column;

}