third_party/WebKit/Source/web/WebPagePopupImpl.cpp - Issue 2919653004: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2919653004: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH (Closed)

Patch Set: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

index e7aa9b199cd217a74870e5a72f9ea7e81c49569a..15fdc467a7e682754c5b482c67f069e5cb1c31a5 100644

--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

@@ -599,8 +599,7 @@ WebRect WebPagePopupImpl::WindowRectInScreen() const {

// WebPagePopup ----------------------------------------------------------------

WebPagePopup* WebPagePopup::Create(WebWidgetClient* client) {

- if (!client)

- IMMEDIATE_CRASH();

+ LOG_IF(FATAL, !client);

// A WebPagePopupImpl instance usually has two references.

// - One owned by the instance itself. It represents the visible widget.

// - One owned by a WebViewBase. It's released when the WebViewBase ask the