third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp - Issue 2919653004: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp

Issue 2919653004: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH (Closed)

Patch Set: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp

diff --git a/third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp b/third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp

index abaa2a7521bc8c3c2e0403146e8dd1dfbf2d7f67..b671be6fc2bdbf82c845edd9146b06908d05a676 100644

--- a/third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp

+++ b/third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp

@@ -28,8 +28,8 @@ TEST(AssertionsTest, Assertions) {

SECURITY_CHECK(true);

EXPECT_DEATH_IF_SUPPORTED(SECURITY_CHECK(false), "");

- EXPECT_DEATH_IF_SUPPORTED(IMMEDIATE_CRASH(), "");

+ EXPECT_DEATH_IF_SUPPORTED(LOG(FATAL), "");

tkent 2017/06/02 00:26:49 LOG() is defined by base/logging.*, Blink doesn't

gyuyoung 2017/06/02 14:45:46 Done.

+ EXPECT_DEATH_IF_SUPPORTED(LOG(FATAL), "");

};

#if !LOG_DISABLED