third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp - Issue 2919653004: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

Issue 2919653004: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH (Closed)

Patch Set: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

diff --git a/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp b/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

index d60272e9478945193c15df6c49322c8a7fad15a5..5e93254c484fe722a755671df46f2676df51a9c2 100644

--- a/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

+++ b/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

@@ -344,17 +344,17 @@ bool XSLTProcessor::TransformToString(Node* source_node,

xsltSecurityPrefsPtr security_prefs = xsltNewSecurityPrefs();

// Read permissions are checked by docLoaderFunc.

- if (0 != xsltSetSecurityPrefs(security_prefs, XSLT_SECPREF_WRITE_FILE,

- xsltSecurityForbid))

- IMMEDIATE_CRASH();

- if (0 != xsltSetSecurityPrefs(security_prefs, XSLT_SECPREF_CREATE_DIRECTORY,

- xsltSecurityForbid))

- IMMEDIATE_CRASH();

- if (0 != xsltSetSecurityPrefs(security_prefs, XSLT_SECPREF_WRITE_NETWORK,

- xsltSecurityForbid))

- IMMEDIATE_CRASH();

- if (0 != xsltSetCtxtSecurityPrefs(security_prefs, transform_context))

- IMMEDIATE_CRASH();

+ LOG_IF(FATAL,

+ 0 != xsltSetSecurityPrefs(security_prefs, XSLT_SECPREF_WRITE_FILE,

+ xsltSecurityForbid));

+ LOG_IF(FATAL, 0 != xsltSetSecurityPrefs(security_prefs,

+ XSLT_SECPREF_CREATE_DIRECTORY,

+ xsltSecurityForbid));

+ LOG_IF(FATAL,

+ 0 != xsltSetSecurityPrefs(security_prefs, XSLT_SECPREF_WRITE_NETWORK,

+ xsltSecurityForbid));

+ LOG_IF(FATAL,

+ 0 != xsltSetCtxtSecurityPrefs(security_prefs, transform_context));

// <http://bugs.webkit.org/show_bug.cgi?id=16077>: XSLT processor

// <xsl:sort> algorithm only compares by code point.