third_party/WebKit/Source/platform/wtf/text/TextCodecUTF8.cpp - Issue 2919653004: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/wtf/text/TextCodecUTF8.cpp

Issue 2919653004: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH (Closed)

Patch Set: Use LOG() or CHECK()|CHECK_FOO() instead of IMMEDIATE_CRASH Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/wtf/text/TextCodecUTF8.cpp

diff --git a/third_party/WebKit/Source/platform/wtf/text/TextCodecUTF8.cpp b/third_party/WebKit/Source/platform/wtf/text/TextCodecUTF8.cpp

index 55f0ce5834fd0ca8f9173d15ab70121b3538c997..315f451bd9a97e769fd67696af0b7d7df95d9e07 100644

--- a/third_party/WebKit/Source/platform/wtf/text/TextCodecUTF8.cpp

+++ b/third_party/WebKit/Source/platform/wtf/text/TextCodecUTF8.cpp

@@ -463,8 +463,7 @@ CString TextCodecUTF8::EncodeCommon(const CharType* characters, size_t length) {

// (3x).

// Non-BMP characters take two UTF-16 code units and can take up to 4 bytes

// (2x).

- if (length > std::numeric_limits<size_t>::max() / 3)

- IMMEDIATE_CRASH();

+ CHECK_LE(length, std::numeric_limits<size_t>::max() / 3);

Vector<uint8_t> bytes(length * 3);

size_t i = 0;