third_party/WebKit/Source/platform/mac/BlockExceptions.mm - Issue 2919653004: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/mac/BlockExceptions.mm

Issue 2919653004: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH (Closed)

Patch Set: Use LOG() or CHECK()|CHECK_FOO() instead of IMMEDIATE_CRASH Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/mac/BlockExceptions.mm

diff --git a/third_party/WebKit/Source/platform/mac/BlockExceptions.mm b/third_party/WebKit/Source/platform/mac/BlockExceptions.mm

index 6ae8c8936b71dcdbe994d9cf72b4f3387a99c64f..b1b06e71e7477c5666c9696a63be4c98e1697268 100644

--- a/third_party/WebKit/Source/platform/mac/BlockExceptions.mm

+++ b/third_party/WebKit/Source/platform/mac/BlockExceptions.mm

@@ -33,7 +33,7 @@ void ReportBlockedObjCException(NSException* exception) {

<< [[exception description] UTF8String];

// This function is marked as NO_RETURN_DUE_TO_ASSERT, but NOTREACHED() and

// DCHECK(false) are not recognized as NO_RETURN.

- IMMEDIATE_CRASH();

+ LOG(FATAL);

#else

NSLog(@"*** WebKit discarding exception: <%@> %@", [exception name],

[exception reason]);