third_party/WebKit/Source/core/layout/LayoutText.cpp - Issue 2919653004: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutText.cpp

Issue 2919653004: Use LOG() or LOG_IF() instead of IMMEDIATE_CRASH (Closed)

Patch Set: Use LOG() or CHECK()|CHECK_FOO() instead of IMMEDIATE_CRASH Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutText.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutText.cpp b/third_party/WebKit/Source/core/layout/LayoutText.cpp

index 8753bc158fe62257cb037b77494acbbdc843f128..80f0ce2b8b746a18a832f6885cb67581a420a980 100644

--- a/third_party/WebKit/Source/core/layout/LayoutText.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutText.cpp

@@ -109,9 +109,7 @@ static void MakeCapitalized(String* string, UChar previous) {

unsigned length = string->length();

const StringImpl& input = *string->Impl();

- if (length >= std::numeric_limits<unsigned>::max())

- IMMEDIATE_CRASH();

+ CHECK_LT(length, std::numeric_limits<unsigned>::max());

StringBuffer<UChar> string_with_previous(length + 1);

string_with_previous[0] =

previous == kNoBreakSpaceCharacter ? kSpaceCharacter : previous;