Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 291963002: Convert apk-package-resources.xml to python (Closed)

Created:
6 years, 7 months ago by cjhopman
Modified:
6 years, 6 months ago
Reviewers:
Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, newt (away)
Visibility:
Public.

Description

Convert apk-package-resources.xml to python This ant script is basically a simple wrapper around an aapt call (the only thing the large AaptExecTask custom ant task adds is a bunch of dependency checking that we don't actually want anyway). This makes it use python instead. BUG=359249, 375324, 375431 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273326

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -153 lines) Patch
M build/android/ant/apk-package.xml View 1 chunk +1 line, -1 line 0 comments Download
D build/android/ant/apk-package-resources.xml View 1 chunk +0 lines, -113 lines 0 comments Download
A build/android/gyp/package_resources.py View 1 chunk +93 lines, -0 lines 0 comments Download
M build/java.gypi View 1 chunk +8 lines, -3 lines 0 comments Download
M build/java_apk.gypi View 1 2 6 chunks +50 lines, -36 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
cjhopman
yfriedman: *
6 years, 7 months ago (2014-05-19 20:18:18 UTC) #1
Yaron
lgtm Seems like you're nuking our dependencies on Ant? Is that for gn? Either way, ...
6 years, 7 months ago (2014-05-20 01:43:37 UTC) #2
cjhopman
https://codereview.chromium.org/291963002/diff/20001/build/java_apk.gypi File build/java_apk.gypi (left): https://codereview.chromium.org/291963002/diff/20001/build/java_apk.gypi#oldcode442 build/java_apk.gypi:442: 'resource_additional_options': [], On 2014/05/20 01:43:37, Yaron wrote: > Just ...
6 years, 7 months ago (2014-05-20 21:01:51 UTC) #3
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 6 months ago (2014-05-28 17:53:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/291963002/60001
6 years, 6 months ago (2014-05-28 17:54:11 UTC) #5
cjhopman
The CQ bit was unchecked by cjhopman@chromium.org
6 years, 6 months ago (2014-05-28 19:47:27 UTC) #6
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 6 months ago (2014-05-28 19:47:28 UTC) #7
cjhopman
NOTRY to bypass presubmit, all android bots have passed
6 years, 6 months ago (2014-05-28 19:47:44 UTC) #8
cjhopman
The CQ bit was unchecked by cjhopman@chromium.org
6 years, 6 months ago (2014-05-28 19:47:49 UTC) #9
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 6 months ago (2014-05-28 19:47:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/291963002/60001
6 years, 6 months ago (2014-05-28 19:48:28 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 19:50:11 UTC) #12
Message was sent while issue was closed.
Change committed as 273326

Powered by Google App Engine
This is Rietveld 408576698