Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1623)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2919623002: Implement type inference for PropertySet. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -62 lines) Patch
M pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 5 chunks +12 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +22 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/testing/validating_instrumentation.dart View 1 chunk +11 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 1 chunk +35 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/testing/suite.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_factory.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_factory.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_named_factory.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_named_factory.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_inside_top_level.dart View 1 chunk +4 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/downwards_inference_inside_top_level.dart.strong.expect View 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_property.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_property_custom.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_ref.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_ref.dart.strong.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/infer_from_complex_expressions_if_outer_most_value_is_precise.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/inferred_type_cascade.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/inference/propagate_inference_transitively.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/propagate_inference_transitively.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
A pkg/front_end/testcases/inference/property_set.dart View 1 chunk +49 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/property_set.dart.direct.expect View 1 chunk +34 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/property_set.dart.outline.expect View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/property_set.dart.strong.expect View 1 chunk +34 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/inference/property_set_bad_setter.dart View 1 chunk +6 lines, -7 lines 0 comments Download
A + pkg/front_end/testcases/inference/property_set_bad_setter.dart.direct.expect View 1 chunk +3 lines, -6 lines 0 comments Download
A pkg/front_end/testcases/inference/property_set_bad_setter.dart.outline.expect View 1 chunk +14 lines, -0 lines 0 comments Download
A + pkg/front_end/testcases/inference/property_set_bad_setter.dart.strong.expect View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 6 months ago (2017-05-31 21:15:13 UTC) #2
scheglov
LGTM, but hopefully can be changed to getTypeAsInstanceOf().
3 years, 6 months ago (2017-05-31 21:43:20 UTC) #3
Paul Berry
On 2017/05/31 21:43:20, scheglov wrote: > LGTM, but hopefully can be changed to getTypeAsInstanceOf(). Thanks. ...
3 years, 6 months ago (2017-05-31 21:57:49 UTC) #4
Paul Berry
3 years, 6 months ago (2017-05-31 22:09:33 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
cd5bacbc54b89d83ffd041aa76a81e0e62da42dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698