[DMC #27] Move TextMatchMarker method implementations to TextMatchMarker.cpp

third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Neither the name of Google Inc. nor the names of its
@@ skipping 25 matching lines @@
 // markers. We store whether or not the match is active, a LayoutRect used for
 // rendering the marker, and whether or not the LayoutRect is currently
 // up-to-date.
 class CORE_EXPORT TextMatchMarker final : public DocumentMarker {
  private:
   enum class State { kInvalid, kValidNull, kValidNotNull };
 
  public:
   enum class MatchStatus { kInactive, kActive };
 
-  TextMatchMarker(unsigned start_offset,
-                  unsigned end_offset,
-                  MatchStatus status)
-      : DocumentMarker(start_offset, end_offset), match_status_(status) {
-    layout_state_ = State::kInvalid;
-  }
+  TextMatchMarker(unsigned start_offset, unsigned end_offset, MatchStatus);
 
   // DocumentMarker implementations
   MarkerType GetType() const final;
 
   // TextMatchMarker-specific
-  bool IsActiveMatch() const { return match_status_ == MatchStatus::kActive; }
-  void SetIsActiveMatch(bool active) {
-    match_status_ = active ? MatchStatus::kActive : MatchStatus::kInactive;
-  }
+  bool IsActiveMatch() const;
+  void SetIsActiveMatch(bool active);
 
-  bool IsRendered() const { return layout_state_ == State::kValidNotNull; }
-  bool Contains(const LayoutPoint& point) const {
-    DCHECK_EQ(layout_state_, State::kValidNotNull);
-    return rendered_rect_.Contains(point);
-  }
-  void SetRenderedRect(const LayoutRect& rect) {
-    if (layout_state_ == State::kValidNotNull && rect == rendered_rect_)
-      return;
-    layout_state_ = State::kValidNotNull;
-    rendered_rect_ = rect;
-  }
+  bool IsRendered() const;
+  bool Contains(const LayoutPoint&) const;
+  void SetRenderedRect(const LayoutRect&);
 

[Xiaocheng, 2017/06/01 21:42:50]

nit: Could you remove the empty lines at L58, L60 and L62?

-  const LayoutRect& RenderedRect() const {
-    DCHECK_EQ(layout_state_, State::kValidNotNull);
-    return rendered_rect_;
-  }
+  const LayoutRect& RenderedRect() const;
 
-  void NullifyRenderedRect() {
-    layout_state_ = State::kValidNull;
-    // Now |m_renderedRect| can not be accessed until |setRenderedRect| is
-    // called.
-  }
+  void NullifyRenderedRect();
 
-  void Invalidate() { layout_state_ = State::kInvalid; }
-  bool IsValid() const { return layout_state_ != State::kInvalid; }
+  void Invalidate();
+  bool IsValid() const;
 
  private:
   MatchStatus match_status_;
   LayoutRect rendered_rect_;
   State layout_state_;
 
   DISALLOW_COPY_AND_ASSIGN(TextMatchMarker);
 };
 
 DEFINE_TYPE_CASTS(TextMatchMarker,
                   DocumentMarker,
                   marker,
                   marker->GetType() == DocumentMarker::kTextMatch,
                   marker.GetType() == DocumentMarker::kTextMatch);
 
 }  // namespace blink
 
 #endif