Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 2919593007: Always update the omnibox URL when cancelling via onbeforeunload (Closed)
Patch Set: Test tweaking Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <functional> 10 #include <functional>
(...skipping 546 matching lines...) Expand 10 before | Expand all | Expand 10 after
557 void RenderViewCreated(RenderViewHost* render_view_host) override; 557 void RenderViewCreated(RenderViewHost* render_view_host) override;
558 void RenderViewReady(RenderViewHost* render_view_host) override; 558 void RenderViewReady(RenderViewHost* render_view_host) override;
559 void RenderViewTerminated(RenderViewHost* render_view_host, 559 void RenderViewTerminated(RenderViewHost* render_view_host,
560 base::TerminationStatus status, 560 base::TerminationStatus status,
561 int error_code) override; 561 int error_code) override;
562 void RenderViewDeleted(RenderViewHost* render_view_host) override; 562 void RenderViewDeleted(RenderViewHost* render_view_host) override;
563 void UpdateTargetURL(RenderViewHost* render_view_host, 563 void UpdateTargetURL(RenderViewHost* render_view_host,
564 const GURL& url) override; 564 const GURL& url) override;
565 void Close(RenderViewHost* render_view_host) override; 565 void Close(RenderViewHost* render_view_host) override;
566 void RequestMove(const gfx::Rect& new_bounds) override; 566 void RequestMove(const gfx::Rect& new_bounds) override;
567 void DidCancelLoading() override;
568 void DocumentAvailableInMainFrame(RenderViewHost* render_view_host) override; 567 void DocumentAvailableInMainFrame(RenderViewHost* render_view_host) override;
569 void RouteCloseEvent(RenderViewHost* rvh) override; 568 void RouteCloseEvent(RenderViewHost* rvh) override;
570 bool DidAddMessageToConsole(int32_t level, 569 bool DidAddMessageToConsole(int32_t level,
571 const base::string16& message, 570 const base::string16& message,
572 int32_t line_no, 571 int32_t line_no,
573 const base::string16& source_id) override; 572 const base::string16& source_id) override;
574 RendererPreferences GetRendererPrefs( 573 RendererPreferences GetRendererPrefs(
575 BrowserContext* browser_context) const override; 574 BrowserContext* browser_context) const override;
576 void OnUserInteraction(RenderWidgetHostImpl* render_widget_host, 575 void OnUserInteraction(RenderWidgetHostImpl* render_widget_host,
577 const blink::WebInputEvent::Type type) override; 576 const blink::WebInputEvent::Type type) override;
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
875 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostManagerTest, PageDoesBackAndReload); 874 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostManagerTest, PageDoesBackAndReload);
876 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest, CrossSiteIframe); 875 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest, CrossSiteIframe);
877 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest, 876 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest,
878 TwoSubframesCreatePopupsSimultaneously); 877 TwoSubframesCreatePopupsSimultaneously);
879 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest, 878 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest,
880 TwoSubframesCreatePopupMenuWidgetsSimultaneously); 879 TwoSubframesCreatePopupMenuWidgetsSimultaneously);
881 FRIEND_TEST_ALL_PREFIXES(SitePerProcessAccessibilityBrowserTest, 880 FRIEND_TEST_ALL_PREFIXES(SitePerProcessAccessibilityBrowserTest,
882 CrossSiteIframeAccessibility); 881 CrossSiteIframeAccessibility);
883 FRIEND_TEST_ALL_PREFIXES(WebContentsImplBrowserTest, 882 FRIEND_TEST_ALL_PREFIXES(WebContentsImplBrowserTest,
884 JavaScriptDialogsInMainAndSubframes); 883 JavaScriptDialogsInMainAndSubframes);
884 FRIEND_TEST_ALL_PREFIXES(WebContentsImplBrowserTest,
885 DismissingBeforeUnloadDialogInvalidatesUrl);
885 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest, 886 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest,
886 IframeBeforeUnloadParentHang); 887 IframeBeforeUnloadParentHang);
887 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest, 888 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest,
888 BeforeUnloadDialogRequiresGesture); 889 BeforeUnloadDialogRequiresGesture);
889 890
890 // So |find_request_manager_| can be accessed for testing. 891 // So |find_request_manager_| can be accessed for testing.
891 friend class FindRequestManagerTest; 892 friend class FindRequestManagerTest;
892 893
893 // TODO(brettw) TestWebContents shouldn't exist! 894 // TODO(brettw) TestWebContents shouldn't exist!
894 friend class TestWebContents; 895 friend class TestWebContents;
(...skipping 700 matching lines...) Expand 10 before | Expand all | Expand 10 after
1595 // Adds/removes a callback called on creation of each new WebContents. 1596 // Adds/removes a callback called on creation of each new WebContents.
1596 static void AddCreatedCallbackForTesting(const CreatedCallback& callback); 1597 static void AddCreatedCallbackForTesting(const CreatedCallback& callback);
1597 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback); 1598 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback);
1598 1599
1599 DISALLOW_COPY_AND_ASSIGN(FriendWrapper); 1600 DISALLOW_COPY_AND_ASSIGN(FriendWrapper);
1600 }; 1601 };
1601 1602
1602 } // namespace content 1603 } // namespace content
1603 1604
1604 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 1605 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698