Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2919573003: Revert "Revert "Replace the configuration map with a typed object."" (Closed)

Created:
3 years, 6 months ago by Bob Nystrom
Modified:
3 years, 6 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Revert "Replace the configuration map with a typed object."" This reverts commit 8bada4873ad171fe031d8c9a69ddca95131b1d94. R=nweiz@google.com Committed: https://github.com/dart-lang/sdk/commit/7e2d9ac85de41122144be246f10700ec2d5c715b

Patch Set 1 #

Patch Set 2 : Fix test.dart tests. #

Patch Set 3 : Another test fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1937 lines, -1471 lines) Patch
M tests/lib/lib.status View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/test_runner_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/standalone.status View 1 3 chunks +4 lines, -2 lines 0 comments Download
M tests/standalone/status_expression_test.dart View 1 2 4 chunks +20 lines, -12 lines 0 comments Download
M tools/testing/dart/browser_controller.dart View 16 chunks +62 lines, -70 lines 0 comments Download
M tools/testing/dart/co19_test.dart View 2 chunks +6 lines, -7 lines 0 comments Download
M tools/testing/dart/co19_test_config.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 13 chunks +99 lines, -119 lines 0 comments Download
A tools/testing/dart/configuration.dart View 1 chunk +741 lines, -0 lines 0 comments Download
M tools/testing/dart/drt_updater.dart View 2 chunks +8 lines, -9 lines 0 comments Download
A tools/testing/dart/environment.dart View 1 chunk +105 lines, -0 lines 0 comments Download
M tools/testing/dart/expectation_set.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M tools/testing/dart/http_server.dart View 4 chunks +8 lines, -9 lines 0 comments Download
M tools/testing/dart/launch_browser.dart View 2 chunks +6 lines, -4 lines 0 comments Download
M tools/testing/dart/main.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/options.dart View 16 chunks +214 lines, -348 lines 0 comments Download
M tools/testing/dart/package_testing_support.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 4 chunks +69 lines, -67 lines 0 comments Download
M tools/testing/dart/status_expression.dart View 6 chunks +30 lines, -6 lines 0 comments Download
M tools/testing/dart/status_file.dart View 6 chunks +52 lines, -16 lines 0 comments Download
M tools/testing/dart/status_reporter.dart View 5 chunks +79 lines, -90 lines 0 comments Download
M tools/testing/dart/test_configurations.dart View 11 chunks +85 lines, -119 lines 0 comments Download
M tools/testing/dart/test_progress.dart View 7 chunks +40 lines, -49 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 21 chunks +57 lines, -71 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 53 chunks +235 lines, -400 lines 0 comments Download
M tools/testing/dart/utils.dart View 2 chunks +0 lines, -56 lines 0 comments Download
M tools/testing/dart/vm_test_config.dart View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
The first patch set was reviewed (https://codereview.chromium.org/2920633002/) so you can ignore that. The other two ...
3 years, 6 months ago (2017-05-31 22:37:36 UTC) #2
nweiz
lgtm
3 years, 6 months ago (2017-05-31 22:38:47 UTC) #3
Bob Nystrom
3 years, 6 months ago (2017-05-31 22:39:28 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:30001) manually as
7e2d9ac85de41122144be246f10700ec2d5c715b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698