chrome/renderer/translate/translate_helper_browsertest.cc - Issue 2919343007: Check |errorCode| of translate.js and notify to Browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/translate/translate_helper_browsertest.cc

Issue 2919343007: Check |errorCode| of translate.js and notify to Browser (Closed)

Patch Set: Added test cases to check for translate error types and a minor refactoring. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/translate/translate_helper_browsertest.cc

diff --git a/chrome/renderer/translate/translate_helper_browsertest.cc b/chrome/renderer/translate/translate_helper_browsertest.cc

index 679b62803a798fb432ee3297c481dec8d4eeb2ba..814fef444acd7451ca590efa7188da97720eb2c9 100644

--- a/chrome/renderer/translate/translate_helper_browsertest.cc

+++ b/chrome/renderer/translate/translate_helper_browsertest.cc

@@ -189,7 +189,7 @@ TEST_F(TranslateHelperBrowserTest, TranslateLibNeverReady) {

translate::TranslateErrors::Type error;

ASSERT_TRUE(translate_helper_->GetPageTranslatedResult(NULL, NULL, &error));

- EXPECT_EQ(translate::TranslateErrors::INITIALIZATION_ERROR, error);

+ EXPECT_EQ(translate::TranslateErrors::TRANSLATION_TIMEOUT, error);

}

// Tests that the browser gets notified of the translation success when the