Check |errorCode| of translate.js and notify to Browser

chrome/renderer/translate/translate_helper_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <tuple>
 
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/time/time.h"
 #include "chrome/common/chrome_isolated_world_ids.h"
@@ skipping 94 matching lines @@
     if (error)
       *error = trans_result_error_type_;
     return true;
   }
 
   MOCK_METHOD0(IsTranslateLibAvailable, bool());
   MOCK_METHOD0(IsTranslateLibReady, bool());
   MOCK_METHOD0(HasTranslationFinished, bool());
   MOCK_METHOD0(HasTranslationFailed, bool());
   MOCK_METHOD0(GetOriginalPageLanguage, std::string());
+  MOCK_METHOD0(GetErrorCode, int64_t());
   MOCK_METHOD0(StartTranslation, bool());
   MOCK_METHOD1(ExecuteScript, void(const std::string&));
   MOCK_METHOD2(ExecuteScriptAndGetBoolResult, bool(const std::string&, bool));
   MOCK_METHOD1(ExecuteScriptAndGetStringResult,
                std::string(const std::string&));
   MOCK_METHOD1(ExecuteScriptAndGetDoubleResult, double(const std::string&));
 
  private:
   void OnPageTranslated(bool cancelled,
                         const std::string& original_lang,
@@ skipping 52 matching lines @@
   // library.
   EXPECT_CALL(*translate_helper_, IsTranslateLibAvailable())
       .Times(AtLeast(1))
       .WillRepeatedly(Return(true));
 
   EXPECT_CALL(*translate_helper_, IsTranslateLibReady())
       .Times(AtLeast(5))  // See kMaxTranslateInitCheckAttempts in
                           // translate_helper.cc
       .WillRepeatedly(Return(false));
 
+  EXPECT_CALL(*translate_helper_, GetErrorCode())
+      .Times(AtLeast(5))
+      .WillRepeatedly(Return(0));
+
   translate_helper_->TranslatePage("en", "fr", std::string());
   base::RunLoop().RunUntilIdle();
 
   translate::TranslateErrors::Type error;
   ASSERT_TRUE(translate_helper_->GetPageTranslatedResult(NULL, NULL, &error));
-  EXPECT_EQ(translate::TranslateErrors::INITIALIZATION_ERROR, error);
+  EXPECT_EQ(translate::TranslateErrors::TRANSLATION_TIMEOUT, error);
 }
 
 // Tests that the browser gets notified of the translation success when the
 // translation succeeds.
 TEST_F(TranslateHelperBrowserTest, TranslateSuccess) {
   // We make IsTranslateLibAvailable true so we don't attempt to inject the
   // library.
   EXPECT_CALL(*translate_helper_, IsTranslateLibAvailable())
       .Times(AtLeast(1))
       .WillRepeatedly(Return(true));
 
   EXPECT_CALL(*translate_helper_, IsTranslateLibReady())
       .WillOnce(Return(false))
       .WillOnce(Return(true));
 
+  EXPECT_CALL(*translate_helper_, GetErrorCode()).WillOnce(Return(0));
+
   EXPECT_CALL(*translate_helper_, StartTranslation()).WillOnce(Return(true));
 
   // Succeed after few checks.
   EXPECT_CALL(*translate_helper_, HasTranslationFailed())
       .WillRepeatedly(Return(false));
   EXPECT_CALL(*translate_helper_, HasTranslationFinished())
       .WillOnce(Return(false))
       .WillOnce(Return(false))
       .WillOnce(Return(true));
 
@@ skipping 34 matching lines @@
   EXPECT_CALL(*translate_helper_, HasTranslationFailed())
       .WillOnce(Return(false))
       .WillOnce(Return(false))
       .WillOnce(Return(false))
       .WillOnce(Return(true));
 
   EXPECT_CALL(*translate_helper_, HasTranslationFinished())
       .Times(AtLeast(1))
       .WillRepeatedly(Return(false));
 
+  EXPECT_CALL(*translate_helper_, GetErrorCode())
+      .WillOnce(Return(6));  // TRANSLATION_ERROR = 6

[Takashi Toyoshima, 2017/06/29 11:59:15]

why don't you use translate::TranslationErrors::TRANSLATION_ERROR?

Ditto for other returning 0 cases.

+
   // V8 call for performance monitoring should be ignored.
   EXPECT_CALL(*translate_helper_,
               ExecuteScriptAndGetDoubleResult(_)).Times(2);
 
   translate_helper_->TranslatePage("en", "fr", std::string());
   base::RunLoop().RunUntilIdle();
 
   translate::TranslateErrors::Type error;
   ASSERT_TRUE(translate_helper_->GetPageTranslatedResult(NULL, NULL, &error));
   EXPECT_EQ(translate::TranslateErrors::TRANSLATION_ERROR, error);
@@ skipping 226 matching lines @@
 
   GoBack(GURL("data:text/html;charset=utf-8,<html><head>"
               "<meta http-equiv=\"content-language\" content=\"zh\">"
               "</head><body>This page is in Chinese.</body></html>"),
          back_state);
 
   base::RunLoop().RunUntilIdle();
   ASSERT_TRUE(fake_translate_driver_.called_new_page_);
   EXPECT_EQ("zh", fake_translate_driver_.details_->adopted_language);
 }